[BUG] Bottom navigation is still visible when user searches while in My Lists or History
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Mar 16 2017, 1:51 PM

Description

Steps to reproduce

Go to the Reading list/History tab in the app
Tap on the search icon

Expected

Search mode is invoked with keyboard appearing on screen and bottom navigation bar no longer visible.
(per Material spec, keyboards are at a higher elevation so should appear over and cover bottom nav bars)

Actual

Bottom nav bar is still visible as it appears 'stuck' to the top of the keyboard and moves with it up the screen.

main-MainActivity-03152017150840.png (1×1 px, 115 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Hide bottom navigation when ActionMode active.	apps/android/wikipedia	master	+33 -55
	Hide bottom navigation when ActionMode active.	apps/android/wikipedia	master	+28 -49

Customize query in gerrit

Related Objects

Mentioned In: T156071: Update visual treatment of Search on Reading lists and History screens

Event Timeline

RHo created this task.Mar 16 2017, 1:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2017, 1:51 PM

RHo mentioned this in T156071: Update visual treatment of Search on Reading lists and History screens.Mar 16 2017, 1:55 PM

Change 343067 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia] Hide bottom navigation when ActionMode active.

https://gerrit.wikimedia.org/r/343067

Change 343067 abandoned by Dbrant:
Hide bottom navigation when ActionMode active.

https://gerrit.wikimedia.org/r/343067

Change 343070 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia] Hide bottom navigation when ActionMode active.

https://gerrit.wikimedia.org/r/343070

Dbrant claimed this task.Mar 16 2017, 3:30 PM

Dbrant added a project: Android-app-release-v2.5.19x-Ananas🍍.

Dbrant moved this task from To Do to Code Review on the Android-app-release-v2.5.19x-Ananas🍍 board.

Change 343070 merged by jenkins-bot:
[apps/android/wikipedia] Hide bottom navigation when ActionMode active.

https://gerrit.wikimedia.org/r/343070

Dbrant moved this task from Code Review to QA Signoff on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 20 2017, 6:21 PM

Testing on Samsung Galaxy Express 3 (J120A) with Android 6.0.1 and Wikipedia Alpha app 2.5.190-alpha-2017-03-21. This is fixed as bottom navigation bar disappears when keyboard appears both for the Reading List

T160636 Reading List Step 1.png (800×480 px, 26 KB)

T160636 Reading List Step 2.png (800×480 px, 50 KB)

and for the History tab

T160636 History Step 1.png (800×480 px, 51 KB)

T160636 History Step 2.png (800×480 px, 65 KB)

• NHarateh_WMF removed a project: Wikipedia-Android-App-Backlog.Mar 22 2017, 4:20 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptMar 22 2017, 4:20 PM

• NHarateh_WMF removed a project: Wikipedia-Android-App-Backlog.Mar 22 2017, 4:23 PM

Tested on a Pixel with Android 7.1.1 and the Alpha App 2.5.190-alpha-2017-03-23

Appears to be fixed

Dbrant moved this task from Ready for Signoff to Done on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 29 2017, 4:05 PM

Dbrant closed this task as Resolved.Mar 29 2017, 4:06 PM

	F6829426: T160636 Reading List Step 2.png
	Mar 21 2017, 10:41 PM

	F6829425: T160636 Reading List Step 1.png
	Mar 21 2017, 10:41 PM

	F6593823: main-MainActivity-03152017150840.png
	Mar 16 2017, 1:51 PM

[BUG] Bottom navigation is still visible when user searches while in My Lists or HistoryClosed, ResolvedPublicActions