Page MenuHomePhabricator
Create Task
Maniphest T160656

Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer
Closed, ResolvedPublic
Actions

Description

Proposed solution for T160615: Investigate why changes to Lexeme entity are not shown on the diff page

Have the EntityDiffViewFactory interface that returns instances of DiffView, get it implemented in different entity types using entity type definition class. And use it in EntityDiffVisualizer

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce 'entity-diff-visualizer-callback' in entity type definitionsmediawiki/extensions/Wikibasemaster+20 -1
Introduce DispatchingEntityDiffVisualizer and EntityDiffVisualizerFactorymediawiki/extensions/Wikibasemaster+379 -97
Decouple DiffView and RequestContextmediawiki/extensions/Wikibasemaster+17 -11
Add $entityType attribute to EntityContentDiffmediawiki/extensions/Wikibasemaster+96 -22
Introduce EntityDiffVisualizer interface and use it in BasicEntityDiffVisualizermediawiki/extensions/Wikibasemaster+25 -1
Rename EntityDiffVisualizer to BasicEntityDiffVisualizermediawiki/extensions/Wikibasemaster+11 -11
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Mar 16 2017, 4:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2017, 4:36 PM
daniel added a comment.Mar 16 2017, 4:46 PM

I agree with the general idea, but I would structure the solution a bit differently:

  • turn EntityDiffVisualizer into an interface.
  • create a BasicEntityDiffVisualizer implementation to share code between the implementation for different entity types - or maybe better, an EntityDiffVisualizerHelper (or EntityDiffComponentVisualizer), so we can use composition instead of subclassing.
  • create a DispatchingEntityDiffVisualizer, using callbacks from EntityTypeDefinitions.
WMDE-leszek subscribed.Mar 16 2017, 4:47 PM
WMDE-leszek triaged this task as Medium priority.Mar 21 2017, 11:28 AM
WMDE-leszek mentioned this in T160615: Investigate why changes to Lexeme entity are not shown on the diff page.Mar 22 2017, 12:18 PM
Ladsgroup claimed this task.Mar 22 2017, 1:45 PM
Ladsgroup added a project: MediaWiki-extensions-Wikibase-Repo.
Restricted Application added projects: Wikidata, User-Ladsgroup. · View Herald TranscriptMar 22 2017, 1:45 PM
Ladsgroup moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.Mar 22 2017, 1:45 PM
Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.
Ladsgroup added a comment.Mar 22 2017, 2:08 PM

I started it by doing something very simple: Renaming EntityDiffVisualizer to BasicEntityDiffVisualizer. once this is merged (or in a followup) I make a patch for adding EntityDiffVisualizer as an interface. In a follow-up patch, I make the DispatchingEntityDiffVisualizer then ItemEntityDiffVisualizer.

gerritbot subscribed.Mar 22 2017, 4:38 PM

Change 344146 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename EntityDiffVisualizer to BasicEntityDiffVisualizer

https://gerrit.wikimedia.org/r/344146

Ladsgroup added a comment.Mar 22 2017, 5:59 PM

Made https://gerrit.wikimedia.org/r/344175 now to add the interface and use it. Dispatching will be in another patch.

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Mar 22 2017, 6:00 PM
Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 23 2017, 1:34 PM
gerritbot added a comment.Mar 24 2017, 5:32 PM

Change 344175 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce EntityDiffVisualizer interface and use it in BasicEntityDiffVisualizer

https://gerrit.wikimedia.org/r/344175

Ladsgroup moved this task from Blocked on others to In progress on the User-Ladsgroup board.Mar 27 2017, 10:45 AM
Ladsgroup added a comment.Mar 27 2017, 1:29 PM

Given that gerritbot still doesn't want to add comment when I make a patch:

Ladsgroup mentioned this in T161525: gerritbot doesn't add comment/patch-for-review when User:Ladsgroup creates patch in Gerrit.Mar 27 2017, 3:50 PM
gerritbot added a comment.Mar 30 2017, 2:51 PM

Change 344943 merged by Daniel Kinzler:
[mediawiki/extensions/Wikibase@master] Add $entityType attribute to EntityContentDiff

https://gerrit.wikimedia.org/r/344943

WMDE-leszek moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Apr 10 2017, 8:23 AM
Ladsgroup added a comment.Apr 12 2017, 7:17 PM

For the record there is a very basic patch: https://gerrit.wikimedia.org/r/#/c/345091/

gerritbot added a comment.Oct 6 2017, 4:46 PM

Change 382739 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Decouple DiffView and RequestContext

https://gerrit.wikimedia.org/r/382739

gerritbot added a project: Patch-For-Review.Oct 6 2017, 4:46 PM
gerritbot added a comment.Oct 9 2017, 9:59 AM

Change 382739 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Decouple DiffView and RequestContext

https://gerrit.wikimedia.org/r/382739

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 9 2017, 10:00 AM
gerritbot added a comment.Oct 13 2017, 1:54 PM

Change 384051 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Introduce 'entity-diff-visualizer-callback' in entity type definitions

https://gerrit.wikimedia.org/r/384051

Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Oct 13 2017, 3:50 PM
gerritbot added a comment.Oct 17 2017, 4:17 PM

Change 384051 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce 'entity-diff-visualizer-callback' in entity type definitions

https://gerrit.wikimedia.org/r/384051

gerritbot added a comment.Oct 17 2017, 4:19 PM

Change 345091 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce DispatchingEntityDiffVisualizer and EntityDiffVisualizerFactory

https://gerrit.wikimedia.org/r/345091

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 17 2017, 5:00 PM
WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Oct 18 2017, 6:21 AM
Ladsgroup moved this task from In progress to Done on the User-Ladsgroup board.Nov 2 2017, 4:44 PM
Ladsgroup closed this task as Resolved.Nov 23 2017, 1:38 PM
Ladsgroup removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits