Page MenuHomePhabricator

Wikibase unit tests assume inline <div>s don't get magically re-written as <span>s (holding up the OOUI release)
Closed, ResolvedPublic

Description

The weekly release of OOUI cannot merge because Wikibase seems to have unit tests asserting the string order of how OOUI writes HTML (which is very poor separation of concerns).

I think that the tests are assuming they're getting <div>s but they're now getting <span>s.

Event Timeline

Change 343251 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/Wikidata] SpecialSetSiteLinkTest: Relax test for 'wb-setsitelink-submit' element

https://gerrit.wikimedia.org/r/343251

As usual with Wikibase issues, my main problem is figuring out which repository the fix should go into. The last time this kind of thing happened, I learned that Jenkins uses mediawiki/extensions/Wikidata, so I submitted it there so that we can get the OOUI release merged. I'm hereby making upstreaming it into wherever it really should land a WMDE's problem :)

@matmarex this should be the right place:
/projects/mediawiki/extensions/Wikibase

If you have trouble with finding the right place in the future feel free to poke me on IRC.
Nevertheless, thanks for your efforts.

Thanks. I'll submit a patch for that too, then.

Change 343254 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/Wikibase] SpecialSetSiteLinkTest: Relax test for 'wb-setsitelink-submit' element

https://gerrit.wikimedia.org/r/343254

Change 343251 merged by jenkins-bot:
[mediawiki/extensions/Wikidata] SpecialSetSiteLinkTest: Relax test for 'wb-setsitelink-submit' element

https://gerrit.wikimedia.org/r/343251

Change 343254 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] SpecialSetSiteLinkTest: Relax test for 'wb-setsitelink-submit' element

https://gerrit.wikimedia.org/r/343254

thiemowmde moved this task from incoming to monitoring on the Wikidata board.
thiemowmde subscribed.

Thanks a lot for submitting the patch, @matmarex! As far as I can tell this is resolved, isn't it?

matmarex claimed this task.

Yes, thanks for reviews.