Visual diffing a change to a syntaxHighlight node causes JS error
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Mar 17 2017, 4:40 AM

Description

Go to https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/sandbox?veaction=edit
Edit the code block that begins with var question
Try to view visual diff, get JS error

This happens because ve.ui.DiffElement#compareNodeAttributes calls .static.describeChanges( attributeChanges, attributeChange.newAttributes ); on the node class of the relevant node. Note that 2 parameters are passed. However, ve.dm.MWExtensionNode.static.describeChanges takes three parameters. The third parameter (element) ends up being undefined, and so calling ve.dm.nodeFactory.createFromElement( element ) results in an error.

For extra confusion, note that ve.dm.Model.static.describeChanges is defined to take only one parameter, despite being called with two and all subclasses' implementations taking either two, zero or three parameters.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (a63435906)	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T143341 When re-starting a local draft, show the user a diff so they know what they're getting into
Open	None	T105173 HTML diffs of edits for everything
Resolved	Tchanders	T143350 Let users choose a visual or wikitext diff in the review-your-changes tab
Resolved	Esanders	T160729 Visual diffing a change to a syntaxHighlight node causes JS error

Event Timeline

Catrope created this task.Mar 17 2017, 4:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2017, 4:40 AM

I've also found that this happens for hieroglyph nodes too, but not for math and score nodes, even though they're also subclasses of ve.dm.MWExtensionNode. For some reason, any changes to math and score nodes are rendered in the diff as deleting the old node and inserting the new node, whereas changed to syntaxHighlight and hiero nodes are correctly detected as attribute changes.

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 17 2017, 10:00 PM

Change 343321 had a related patch set uploaded (by Catrope; owner: Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (a63435906)

https://gerrit.wikimedia.org/r/343321

gerritbot added a project: Patch-For-Review.Mar 17 2017, 11:14 PM

Change 343321 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (a63435906)

https://gerrit.wikimedia.org/r/343321

Jdforrester-WMF closed this task as Resolved.Mar 17 2017, 11:41 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)); removed Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 17 2017, 11:41 PM

Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 25 2017, 1:48 AM

Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM