Page MenuHomePhabricator

Allow people to put a MenuToolGroup in a ButtonGroupWidget
Closed, ResolvedPublic1 Estimated Story Points

Description

So we can do T153306

Related Objects

Event Timeline

Change 346179 had a related patch set uploaded (by DLynch):
[oojs/ui@master] Fix theming for Toolbars containing ButtonGroups

https://gerrit.wikimedia.org/r/346179

Patch just generally improves the experience in the mediawiki theme with buttons that aren't direct children of the toolbar but are in a buttongroup. This seems to cover menuToolGroup, but more importantly popupToolGroup which is what I think is actually needed for the dependent tasks of [ Save | v ]. I added a new Toolbar demo, showing that case, since it seems like something people might want to replicate.

I can see the argument for making something like a ButtonDropdownWidget which automates all that creation, if we think it's a common case.

Change 346179 merged by jenkins-bot:
[oojs/ui@master] Fix theming for Toolbars containing ButtonGroups

https://gerrit.wikimedia.org/r/346179

Volker_E edited projects, added OOUI (OOjs-UI-0.21.0); removed OOUI.

I think a major issue here is that the dropdown is a different colour to the primary 'save' button:

pasted_file (74×226 px, 1 KB)

I would expect it to look like this:
pasted_file (74×226 px, 1 KB)

I think a major issue here is that the dropdown is a different colour to the primary 'save' button:

That's pretty much just that PopupToolGroup doesn't mixin Flaggable. (And then if it did, I think the flaggable styles are tightly scoped to ButtonElements, so more theming changes would be needed. Or making it also mixin ButtonElement, I guess.)

Change 346323 had a related patch set uploaded (by DLynch):
[oojs/ui@master] PopupToolGroup: mixin flaggable

https://gerrit.wikimedia.org/r/346323

Change 346323 merged by jenkins-bot:
[oojs/ui@master] PopupToolGroup: Mixin flaggable

https://gerrit.wikimedia.org/r/346323

The list group doesn't style properly when disabled.