So we can do T153306
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| PopupToolGroup: Mixin flaggable | oojs/ui | master | +189 -85 | |
| Fix theming for Toolbars containing ButtonGroups | oojs/ui | master | +51 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T132023 VisualEditor support for editing inside CollaborationKit | |||
| Open | Feature | None | T138636 Allow using VisualEditor on Special:MassMessage | ||
| Open | None | T138642 VisualEditor should provide a clean integrated VE/WT editor widget that can be integrated into any context | |||
| Open | None | T130400 (Actually) Add wikitext support for citoid for automatic reference insertion | |||
| Open | None | T90864 Help VisualEditor users find the wikitext "Save" button | |||
| Open | None | T171974 Improve and consolidate our unified editing platform so that it's great on all devices | |||
| Open | None | T104479 Provide a modern wikitext editor | |||
| Resolved | • Deskana | T44138 VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page | |||
| Open | None | T153306 Have Show preview and Review your changes more directly accessible in the New Wikitext Editor | |||
| Resolved | DLynch | T160791 Allow people to put a MenuToolGroup in a ButtonGroupWidget |
Event Timeline
Comment Actions
Change 346179 had a related patch set uploaded (by DLynch):
[oojs/ui@master] Fix theming for Toolbars containing ButtonGroups
Comment Actions
Patch just generally improves the experience in the mediawiki theme with buttons that aren't direct children of the toolbar but are in a buttongroup. This seems to cover menuToolGroup, but more importantly popupToolGroup which is what I think is actually needed for the dependent tasks of [ Save | v ]. I added a new Toolbar demo, showing that case, since it seems like something people might want to replicate.
I can see the argument for making something like a ButtonDropdownWidget which automates all that creation, if we think it's a common case.
Comment Actions
Change 346179 merged by jenkins-bot:
[oojs/ui@master] Fix theming for Toolbars containing ButtonGroups
Comment Actions
I would expect it to look like this:
I think a major issue here is that the dropdown is a different colour to the primary 'save' button:
I would expect it to look like this:
Comment Actions
I think a major issue here is that the dropdown is a different colour to the primary 'save' button:
That's pretty much just that PopupToolGroup doesn't mixin Flaggable. (And then if it did, I think the flaggable styles are tightly scoped to ButtonElements, so more theming changes would be needed. Or making it also mixin ButtonElement, I guess.)
Comment Actions
Change 346323 had a related patch set uploaded (by DLynch):
[oojs/ui@master] PopupToolGroup: mixin flaggable
Comment Actions
Change 346323 merged by jenkins-bot:
[oojs/ui@master] PopupToolGroup: Mixin flaggable