Description

See parent task. This is a bug against core, bugs for extensions, if needed, should be subtasks of this one.

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+9 -6	FeedUtils: remove usage of $wgLang
mediawiki/core	master	+10 -8	FileDeleteForm: Remove use of $wgLang
mediawiki/core	master	+4 -4	ParserOptionsTest: Rename non-global variable `$wgLang`

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	None	T160814 Deprecate $wgLang
Open	Kizule	T160806 Remove and replace $wgLang in extensions under the social tools umbrella

Event Timeline

SamanthaNguyen created this task.Mar 18 2017, 4:03 AM

SamanthaNguyen added a subtask: T160806: Remove and replace $wgLang in extensions under the social tools umbrella.Mar 18 2017, 4:06 AM

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Aug 13 2018, 11:10 PM

MGChecker added a subscriber: MGChecker.Sep 19 2018, 11:12 PM

One of the more prominent uses in core comes from ContentHandler, seen in most page views when enabling verbose logging:

[wfDebug] [DEBUG] Unstubbing $wgLang on call of $wgLang::unstub from ContentHandler->getPageLanguage

Izno mentioned this in T244383: Replace StubUserLang with a better lazy loading mechanism.Feb 6 2020, 12:20 AM

Change 598143 had a related patch set uploaded (by Krinkle; owner: DannyS712):
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang

https://gerrit.wikimedia.org/r/598143

gerritbot added a project: Patch-For-Review.May 24 2020, 11:11 PM

Change 598143 merged by jenkins-bot:
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang

https://gerrit.wikimedia.org/r/598143

DannyS712 removed a project: Patch-For-Review.May 24 2020, 11:41 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 25 2020, 12:00 AM

@DannyS712 I think most if not all uses of $wgLang are basically safe to replace with something like $userLang = RequestContext::getMain()->getLanguage();. Would you be interested in giving this a try in core and/or some of the deployed extension repos?

Codesearch.

Krinkle triaged this task as Medium priority.Mar 26 2021, 5:20 AM

Krinkle edited projects, added patch-welcome, Performance-Team (Radar); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.

In T160814#6947765, @Krinkle wrote:

@DannyS712 I think most if not all uses of $wgLang are basically safe to replace with something like $userLang = RequestContext::getMain()->getLanguage();. Would you be interested in giving this a try in core and/or some of the deployed extension repos?

Codesearch.

I have a lot on my plate right now, but sure, will look into it. Deliberately *not* claiming this task yet

DannyS712 added a project: User-DannyS712.Mar 26 2021, 2:59 PM

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 674845 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] FileDeleteForm: remove use of $wgLang

https://gerrit.wikimedia.org/r/674845

gerritbot added a project: Patch-For-Review.Mar 26 2021, 3:00 PM

Change 674845 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Remove use of $wgLang

https://gerrit.wikimedia.org/r/674845

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 27 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2021, 3:10 AM

Krinkle merged a task: T244383: Replace StubUserLang with a better lazy loading mechanism.Mar 28 2021, 9:26 PM

Krinkle added subscribers: daniel, Ammarpad, Daimona and 3 others.

Since T244383: Replace StubUserLang with a better lazy loading mechanism was closed as duplicate, I urge to increase priority of this task. StubUserLang keeps causing severe issues. Search for StubUserLang in Wikimedia-production-error yields about 20 tasks.