See parent task. This is a bug against core, bugs for extensions, if needed, should be subtasks of this one.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T11968 Reduce use of global and public variables | |||
Open | None | T159283 Deprecate non-configuration globals | |||
Open | None | T160814 Deprecate $wgLang | |||
Open | Kizule | T160806 Remove and replace $wgLang in extensions under the social tools umbrella |
Event Timeline
One of the more prominent uses in core comes from ContentHandler, seen in most page views when enabling verbose logging:
[wfDebug] [DEBUG] Unstubbing $wgLang on call of $wgLang::unstub from ContentHandler->getPageLanguage
Change 598143 had a related patch set uploaded (by Krinkle; owner: DannyS712):
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang
Change 598143 merged by jenkins-bot:
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang
@DannyS712 I think most if not all uses of $wgLang are basically safe to replace with something like $userLang = RequestContext::getMain()->getLanguage();. Would you be interested in giving this a try in core and/or some of the deployed extension repos?
I have a lot on my plate right now, but sure, will look into it. Deliberately *not* claiming this task yet
Change 674845 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] FileDeleteForm: remove use of $wgLang
Change 674845 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Remove use of $wgLang
Since T244383: Replace StubUserLang with a better lazy loading mechanism was closed as duplicate, I urge to increase priority of this task. StubUserLang keeps causing severe issues. Search for StubUserLang in Wikimedia-production-error yields about 20 tasks.
Change 710570 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] FeedUtils: remove usage of $wgLang
Change 710570 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils: remove usage of $wgLang
Change 936802 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/core@master] Remove $wgLang usage from Title
Change 936802 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgLang usage from Title