EditEntityTest::testEditEntity with data set "new mediainfo from id" (array('%M11%', '{}'), array('mediainfo'), 'mediainfo') test failure
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Mar 19 2017, 12:14 AM

Description

Wikidata build has a test failure inEditEntityTest::testEditEntity related to mediainfo

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/8501/console

10:06:10 1) Wikibase\Repo\Tests\Api\EditEntityTest::testEditEntity with data set "new mediainfo from id" (array('%M11%', '{}'), array('mediainfo'), 'mediainfo')
10:06:10 ApiUsageException: Could not process change request for entity of type: mediainfo
10:06:10 
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/api/ApiUsageException.php:145
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/api/ApiBase.php:1777
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/api/ApiBase.php:2453
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/ApiErrorReporter.php:273
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/ApiErrorReporter.php:251
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/ApiErrorReporter.php:158
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/EditEntity.php:298
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/EditEntity.php:243
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/ModifyEntity.php:241
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/api/ApiMain.php:1542
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/api/ApiMain.php:512
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/includes/api/ApiTestCase.php:99
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/WikibaseApiTestCase.php:96
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/EditEntityTest.php:448
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:400
10:06:10 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:111
10:06:10

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		aude	T160847 EditEntityTest::testEditEntity with data set "new mediainfo from id" (array('%M11%', '{}'), array('mediainfo'), 'mediainfo') test failure
		Resolved		aude	T160860 Implement MediaInfoChangeOpDeserializer

Event Timeline

aude created this task.Mar 19 2017, 12:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2017, 12:14 AM

Issue is that all entity types should now have a change op deserializer callback in their entity type definitions. This is missing in MediaInfo. (see T160860)

Also, it might not be necessary to be testing mediainfo entities directly in Wikibase as we are doing here. (I understand this was a necessary workaround at some point, but maybe what these test cases cover can be tested in MediaInfo now instead of in Wikibase)

aude claimed this task.Mar 19 2017, 7:57 PM

aude added a subtask: T160860: Implement MediaInfoChangeOpDeserializer.

aude added a project: Wikidata-Former-Sprint-Board.

aude moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.

WMDE-leszek closed subtask T160860: Implement MediaInfoChangeOpDeserializer as Resolved.Mar 21 2017, 10:06 AM