Page MenuHomePhabricator

Add a close button to "Your browser timezone setting differs from the timezone setting in your profile, click to reconcile." popup
Open, LowestPublic

Description

Add a close button to the annoying "Your browser timezone setting differs from the timezone setting in your profile, click to reconcile." it sometimes covers bottom most results on boards and so on. Clicking it and choosing "Cancel" removes it but just until you refresh the page..

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper triaged this task as Lowest priority.Apr 4 2017, 12:53 PM

This is intended behaviour introduced last year. I believe we could change it in the js code as i believe they implemented it in js. Though i doint know how or where it is.

In general problems and proposed changes should be discussed with upstream first, see https://phabricator.wikimedia.org/T160866#3113971

@Paladox, do you really think that all of this was intended behavior? Because from where I'm sitting, this is what the interaction looks like:

Phab:  Your browser timezone changed from PST to PDT!  Your Phab setting is still UTC!  You need to click here and update it!
Me:  Um, yeah:  UTC doesn't "spring forward" or "fall back", remember?  There's nothing to change.
Phab:  Your browser timezone changed from PST to PDT!  Your Phab setting is still UTC!  You need to click here and update your timezone!
Me:  Yeah, that's the way I want it:  UTC all the way.
Phab:  Your browser timezone changed from PST to PDT!  Your Phab setting is still UTC!  YOU NEED TO CLICK HERE AND UPDATE FROM UTC TO UTC, AND I WILL NEVER STOP TELLING YOU ABOUT THIS PROBLEM ON EVERY SINGLE PAGE UNTIL YOU CLICK HERE AND UPDATE IT!!!!11!!111

...and frankly, that seems pretty stupid to me. Maybe it ought to just leave us alone when the setting is UTC?

Since the upsteam issue does not seem to be moving anywhere can we just fix this with some local CSS/JS? It is most annoying, especially when using Phabricator on mobile so the popup takes a major part of the screen.

I usually see that popup twice a year, do you see it more often (and if so why)?

I think I mostly avoid clicking on it, because I am not sure what clicking does (it is not obvious that it won't change my TZ preference right away). I guess I can try and see if/when it returns.

The dialog is a bit surprising: The dropdown (!) offers "Ignore conflict" instead of setting a timezone. But that works for me.

Why is "ignore conflict" a temporary state?

Imagine that you're checking Phab on a mobile device while traveling. You depart Germany, and all's well. You land at Heathrow for your connecting flight, where your phone auto-corrects its timezone. You check Phab, and tell it to ignore the timezone conflict. You land in San Francisco, and tell it to ignore the timezone conflict again. You work all week, and fly home. You land at Heathrow, and tell it to ignore the timezone conflict a third time. You get home and tell it to ignore the timezone conflict a fourth time.

If it's as broken as I imagine, can we just turn this feature off?

Those are probably good questions for the upstream developers, if anyone would like to bring them up.

I see this popup very time I load a page, and I'm in here a lot. I prefer UTC time in phab and of course my browser has local time, so that adds up to a lot of annoyance. Just my two cents.

Hmm.... if you explicitly define your timezone (UTC itself is available as an option) on https://phabricator.wikimedia.org/settings/panel/datetime/ and "Save Changes", is that still the case? If it is, is that still shown after choosing "Ignore conflict"?

Yes, that's where I set it, I have changed it and reset it there in the past in hopes that the popup would go away. Nope, still there.