Page MenuHomePhabricator

WatchedItemStoreIntegrationTest fails when coverage is enabled
Closed, ResolvedPublic

Description

https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2645/console

There were 2 failures:

1) WatchedItemStoreIntegrationTest::testUpdateResetAndSetNotificationTimestamp

 Failed asserting that Wikimedia\Rdbms\ResultWrapper Object &0000000023831513000000001899febd (
   'result' => Array &0 ()
   'mAffectedRows' => 1
   '_hasDataForTestClass' => 'WatchedItemStoreIntegrationTest'
   'mLastQuery' => 'UPDATE  unittest_watchlist SET wl_notificationtimestamp = '20200202020202' WHERE wl_user = '16' AND ((wl_namespace = '0' AND wl_title = 'WatchedItemStoreIntegrationTestPage'))'
 ) is true

This failure has been around for a long time, but is now visible because we no longer ignore PHPUnit failures when generating code coverage - per 4c65c6e46fae1a7a1b84cb39c5158a893eb48013.

Event Timeline

Change 344047 had a related patch set uploaded (by Addshore):
[mediawiki/core] Cast to bool in Database::update

https://gerrit.wikimedia.org/r/344047

Change 344047 merged by jenkins-bot:
[mediawiki/core] Cast to bool in Database::update

https://gerrit.wikimedia.org/r/344047

Reedy renamed this task from WatchedItemStoreIntegrationTest fails when coverage is enabeld to WatchedItemStoreIntegrationTest fails when coverage is enabled.Sep 23 2020, 12:57 AM