Maniphest T160962

Fix warnings in Amount staging helper
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

PHP Warning: number_format() expects parameter 1 to be double, string given in /.../gateway_common/Amount.php on line 114

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix amount warnings	mediawiki/extensions/DonationInterface	master	+22 -2

Customize query in gerrit

Event Timeline

Ejegg created this task.Mar 20 2017, 10:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2017, 10:54 PM

Ejegg triaged this task as Medium priority.Mar 20 2017, 10:54 PM

Ejegg set the point value for this task to 1.

• ggellerman moved this task from Triage to Q4 FY21-22 on the Fundraising-Backlog board.Mar 21 2017, 9:11 PM

Ejegg claimed this task.Sep 20 2017, 3:07 PM

Ejegg added a project: Fundraising Sprint RadioActivewear.

Change 379826 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix amount warnings

https://gerrit.wikimedia.org/r/379826

gerritbot added a project: Patch-For-Review.Sep 22 2017, 7:34 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint RadioActivewear board.Sep 22 2017, 7:34 PM

Change 379826 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix amount warnings

https://gerrit.wikimedia.org/r/379826

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 25 2017, 4:00 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint RadioActivewear board.Sep 25 2017, 7:05 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint RadioActivewear board.Sep 26 2017, 12:01 AM

Haven't seen any of these warnings since the last deploy

• DStrine added a project: Unplanned-Sprint-Work.Oct 18 2017, 10:10 PM