Page MenuHomePhabricator
Create Task
Maniphest T160967

[Regression wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open gallery dialog for an existing gallery and make some changes to it
  2. Save the page
  3. Reopen Ve
  4. Click on "Edit" for Gallery context menu

Observed Result:
Gallery dialog does not open and following error appears in the console.
Uncaught TypeError: Cannot read property 'getData' of null

Screen Shot 2017-03-20 at 5.02.40 PM.png (748×1 px, 247 KB)

Details

SubjectRepoBranchLines +/-
ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a valuemediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Mar 21 2017, 12:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2017, 12:03 AM
SamanthaNguyen added a project: Regression.Mar 21 2017, 1:09 AM
Jdforrester-WMF triaged this task as High priority.Mar 21 2017, 2:50 AM
Jdforrester-WMF added projects: MediaWiki-Gallery, VisualEditor-MediaWiki.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF renamed this task from [Regression pre-wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page to [Regression wmf.17] Cannot open Gallery dialog after making some changes to it and saving the page.Mar 21 2017, 6:56 PM
Jdforrester-WMF added subscribers: Tchanders, Esanders.
gerritbot subscribed.Mar 21 2017, 10:30 PM

Change 344041 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value

https://gerrit.wikimedia.org/r/344041

gerritbot added a project: Patch-For-Review.Mar 21 2017, 10:30 PM
gerritbot added a comment.Mar 23 2017, 3:55 PM

Change 344041 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value

https://gerrit.wikimedia.org/r/344041

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 23 2017, 4:01 PM
Ryasmeen closed this task as Resolved.Mar 23 2017, 10:15 PM
Ryasmeen assigned this task to Jdforrester-WMF.
Ryasmeen added a project: Verified.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 23 2017, 10:17 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 24 2017, 12:52 AM
Ryasmeen added a project: Verified-in-Phase0.Mar 30 2017, 8:39 PM
Ryasmeen added a project: Verified-in-Phase2.Apr 13 2017, 12:29 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL