The iOS and Android apps use some similar JS for image widening.
Consolidate the 2 implementations in the "applib" repo.
Mhurd | |
Mar 21 2017, 6:49 PM |
F7614906: IMG_0007.PNG | |
Apr 18 2017, 5:48 PM |
F7614899: IMG_0008.PNG | |
Apr 18 2017, 5:48 PM |
F7508284: Counties of England.PNG | |
Apr 12 2017, 4:25 PM |
F7508286: Letters.PNG | |
Apr 12 2017, 4:25 PM |
F7508285: Kingdom (biology).PNG | |
Apr 12 2017, 4:25 PM |
F7508270: Food.PNG | |
Apr 12 2017, 4:25 PM |
F7361020: food not wide.mov.gif | |
Apr 7 2017, 11:59 PM |
F7362398: england.mov.gif | |
Apr 7 2017, 11:59 PM |
The iOS and Android apps use some similar JS for image widening.
Consolidate the 2 implementations in the "applib" repo.
Here's consolidating image widening into the applib repo: (including fairly comprehensive tests!)
https://github.com/wikimedia/applib/pull/8
Here's the iOS patch for using the consolidated image widening from the applib repo:
https://github.com/wikimedia/wikipedia-ios/pull/1313
Testing criteria:
( @ABorbaWMF - these may be good cases to add to the regression test list )
Examples of article images which SHOULD BE widened:
Examples of images in a article which SHOULD NOT BE widened:
@cmadeo hey, skipping design review on this because it shouldn't change anything - we just moved where the code lives
Testing on iPhone 7 (iOS 10.2.1) and Wikipedia app 5.4.1 (1099). I looked at the photos @ABorbaWMF displayed above on my end,
Food is widened as expected
Tested on an iPhone 7+ with iOS 10.3 and an iPad Mini 2 Retina with iOS 10.2 both running App 5,4,1,1099
I saw the same results as Nicholas on the iPhone. Everything seemed to be fine.
On the iPad it did not appear to widen the images as seen in the example for 'Food' below. Also, there was some strange alignment on the table images.