An error is frequently occurring in logstash. It might be exposing a bug that we are not aware of, and is making it harder to see other bugs in our error logs so we should aim to investigate it and squash it!
Uncommon
Live errors
Stack trace:
/srv/mediawiki/php-1.29.0-wmf.16/extensions/MobileFrontend/includes/skins/SkinMinerva.php(91): SkinMinerva->prepareUserButton(MinervaTemplate)
#1 /srv/mediawiki/php-1.29.0-wmf.16/includes/skins/SkinTemplate.php(249): SkinMinerva->prepareQuickTemplate()
#2 /srv/mediawiki/php-1.29.0-wmf.16/includes/OutputPage.php(2400): SkinTemplate->outputPage()
#3 /srv/mediawiki/php-1.29.0-wmf.16/includes/MediaWiki.php(867): OutputPage->output(boolean)
#4 /srv/mediawiki/php-1.29.0-wmf.16/includes/MediaWiki.php(879): Closure$MediaWiki::main()
#5 /srv/mediawiki/php-1.29.0-wmf.16/includes/MediaWiki.php(521): MediaWiki->main()
#6 /srv/mediawiki/php-1.29.0-wmf.16/index.php(43): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): include(string)
#8 {main}Along with T151838 this contributes for the majority of our noise in our error logs so it would be good to make it go away.
Developer notes
The issue appears to be due to the line so only happens when the user is logged in
$echoSeenTime < $notifLastUnreadTime->getTimestamp( TS_ISO_8601 )
getLastUnreadNotificationTime can return false so this should be a trivial fix.
Acceptance criteria
- False is returned when there are no notifications. A bell should show in this case.