Page MenuHomePhabricator
Create Task
Maniphest T161050

Rewrite CategoryOverlay using composition, adding tests
Closed, DuplicatePublic
Actions

Description

We will rewrite the CategoryOverlay and related components to use composition rather than inheritance. While doing so we will add tests. This will give us much needed information on how to improve all our overlays going forward, while providing some much needed maintenance to the category overlay.

Understandably given the process with which the feature got made, the existing category feature in beta has no unit tests or browser tests. This is a prerequisite for putting any code to stable where we need to maintain it for millions of users and having confidence that it is serving there needs. Note that the redesign of categories may remove the need for some of these tests.

AC

  • browser test for adding a category
  • browser test for viewing list of categories
  • browser test for tabbing between views and displaying hidden categories
  • browser test for clicking to view a category
  • unit tests for CategoryLookupInputWidget
  • unit test for CategoryGateway
  • test covering infinite scroll behaviour

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 21 2017, 9:34 PM
• Tbayer unsubscribed.Mar 21 2017, 10:17 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Mar 29 2017, 9:42 PM
Jdlrobson added a comment.Apr 13 2017, 5:29 PM

We've had a category related regression - T162922 - tests would have protected against this. This is a blocker for pushing this code to stable.

Jdlrobson added a comment.Apr 17 2017, 7:04 PM

... and T163121

phuedx mentioned this in T163530: Categories view in mobile is broken [firefox].Apr 24 2017, 1:41 PM
Jdlrobson updated the task description. (Show Details)Apr 26 2017, 3:28 PM
Jdlrobson mentioned this in T163699: [Regression] Content based categories show up as organization based categories.
Nemo_bis added a comment.Apr 27 2017, 8:21 PM

Would there be a need for tests if MobileFrontend just showed category the same way the normal skin does?

Jdlrobson lowered the priority of this task from Medium to Low.May 25 2017, 4:15 PM
In T161050#3219194, @Nemo_bis wrote:

Would there be a need for tests if MobileFrontend just showed category the same way the normal skin does?

The category HTML are purposely not rendered at the bottom of the skin for the same reason we do not render the list of languages - performance (html bytes) and non mobile friendly (touch areas/position)

Jdlrobson renamed this task from Category feature has no tests to Rewrite CategoryOverlay using composition, adding tests.Mar 19 2018, 11:38 PM
Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson added a project: Epic.Apr 11 2018, 3:53 PM
Jdlrobson moved this task from Needs Prioritization to Epics/Goals on the Web-Team-Backlog board.
Jdlrobson closed subtask T191987: Simplify CategoryOverlay code for readability as Resolved.Oct 3 2018, 9:07 PM
ovasileva added a project: Advanced Mobile Contributions.Nov 28 2018, 7:54 PM
ovasileva moved this task from Backlog to Existing requests on the Advanced Mobile Contributions board.
Jdlrobson mentioned this in T205126: [EPIC] Separate CategoryOverlay responsibilities and add unit tests.Jan 3 2019, 10:58 PM
Jdlrobson closed this task as a duplicate of T205126: [EPIC] Separate CategoryOverlay responsibilities and add unit tests.Jan 3 2019, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits