Page MenuHomePhabricator
Create Task
Maniphest T161152

Pasted ISBNs should trigger the ISBN typing auto-linking
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

In T117165#3105301, @Schnark wrote:

IMHO the behavior got actually worse:

  1. Copy 978-3-642-14564-3
  2. Open a page for editing in VE, type "ISBN ".
  3. Paste the copied ISBN.
  4. Try to get it autolinked.

Result in 1.29.0-wmf.15: It will get linked if (and only if) you type a space.
Result in 1.29.0-alpha: No matter what you do, the ISBN will not be linked.
Desired result: It should get linked either directly after you paste it or at least after your next action (whether you type anything or move the cursor or whatever)

If you delete and re-add the last character it works (because it's typed content), but…

Details

SubjectRepoBranchLines +/-
Check magic link autolink sequences also after pastemediawiki/extensions/VisualEditormaster+4 -4
Update VE core submodule to master (a6c25d08e)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.Sequences: Allow optional execution after pastesVisualEditor/VisualEditormaster+27 -13
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Mar 22 2017, 8:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2017, 8:03 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Mar 22 2017, 8:03 PM
Jdforrester-WMF mentioned this in T117165: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them….
• Elitre subscribed.Mar 23 2017, 6:05 PM
• Whatamidoing-WMF mentioned this in T147180: isbn formatting.Mar 27 2017, 4:55 PM
Jdforrester-WMF merged a task: T161581: Visual Editor wraps ISBNs in nowiki tags.Mar 28 2017, 3:01 PM
Jdforrester-WMF added a subscriber: Jonesey95.
matmarex claimed this task.Mar 28 2017, 3:05 PM
gerritbot subscribed.Mar 28 2017, 8:49 PM

Change 345233 had a related patch set uploaded (by Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ce.Surface: Check sequences after paste

https://gerrit.wikimedia.org/r/345233

gerritbot added a project: Patch-For-Review.Mar 28 2017, 8:49 PM
matmarex added a comment.Mar 28 2017, 9:18 PM

This should resolve the specific example. But we still can't autolink ISBNs inside big pasted blocks of text (unless we detect them to be wikitext).

gerritbot added a comment.Mar 30 2017, 6:00 PM

Change 345620 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Check magic link autolink sequences also after paste

https://gerrit.wikimedia.org/r/345620

gerritbot added a comment.Mar 30 2017, 9:54 PM

Change 345233 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.Sequences: Allow optional execution after pastes

https://gerrit.wikimedia.org/r/345233

gerritbot added a comment.Mar 31 2017, 3:03 AM

Change 345233 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.Sequences: Allow optional execution after pastes

https://gerrit.wikimedia.org/r/345233

gerritbot added a comment.Mar 31 2017, 3:13 AM

Change 345794 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6c25d08e)

https://gerrit.wikimedia.org/r/345794

gerritbot added a comment.Mar 31 2017, 9:12 PM

Change 345794 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6c25d08e)

https://gerrit.wikimedia.org/r/345794

gerritbot added a comment.Mar 31 2017, 9:14 PM

Change 345620 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Check magic link autolink sequences also after paste

https://gerrit.wikimedia.org/r/345620

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 31 2017, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 1 2017, 3:18 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 1 2017, 3:18 PM
Jonesey95 added a comment.May 3 2017, 6:14 AM

This, or something like it (ISBN with number inserted wrapped in nowiki tags) is still happening, even though all of the related bugs appear to be closed. See this April 25, 2017 edit:

https://en.wikipedia.org/w/index.php?title=John_Granger&type=revision&diff=777115220&oldid=777037585

matmarex added a comment.May 3 2017, 5:01 PM

That's probably a case of T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text. We fixed all the cases where you paste just the ISBN number, but the way we apply "autocorrections" currently can't handle the case where the ISBN is pasted together with other text.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL