Page MenuHomePhabricator
Create Task
Maniphest T161199

Unable to open edit page for some old revisions "PHP Fatal: Argument passed to EditPage::displayViewSourcePage() must implement interface Content"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production:

Catchable fatal error: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given in /srv/mediawiki/php-1.31.0-wmf.17/includes/EditPage.php on line 778

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Disable section editing on non-current revision.mediawiki/coremaster+41 -12
Customize query in gerrit

Related Objects

Event Timeline

MoritzMuehlenhoff created this task.Mar 23 2017, 9:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2017, 9:56 AM
Aklapper added a project: MediaWiki-Page-editing.Mar 23 2017, 2:30 PM
matmarex subscribed.Mar 24 2017, 5:22 AM

I can reproduce this here: https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=edit&oldid=749777530&section=999

Conditions:

  • Page is wikitext (or other content model that supports sections)
  • An old revision of that page used a different content model than wikitext (here, it's plaintext)
  • Trying to edit non-existent section of that revision

In this case, getContentObject() returns null, and displayViewSourcePage() doesn't handle that.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 6 2017, 7:02 PM
Jdforrester-WMF triaged this task as Medium priority.Jun 8 2017, 6:07 PM
Jdforrester-WMF added a project: MediaWiki-ContentHandler.
matmarex merged a task: T186885: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given.Feb 9 2018, 8:41 PM
matmarex updated the task description. (Show Details)
matmarex added a subscriber: • demon.
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 16 2018, 7:25 PM
Krinkle subscribed.

Still reproducible with @matmarex's url.

Krinkle renamed this task from Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given to Unable to open edit page for some old revisions "PHP Fatal: Argument passed to EditPage::displayViewSourcePage() must implement interface Content".Sep 16 2018, 7:26 PM
Krinkle changed Risk Rating from N/A to default.
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:07 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
gerritbot added a comment.Mar 30 2020, 11:30 AM

Change 584573 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Handle NULL result from EditPage::getContentObject

https://gerrit.wikimedia.org/r/584573

gerritbot added a project: Patch-For-Review.Mar 30 2020, 11:30 AM
Ammarpad claimed this task.Mar 30 2020, 12:01 PM
Krinkle added a project: Platform Engineering.Mar 30 2020, 4:32 PM
Anomie edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Mar 30 2020, 8:57 PM
Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Apr 1 2020, 5:04 PM
Ammarpad mentioned this in T251680: Disable section editing on non current revision.May 2 2020, 4:24 PM
Ammarpad removed Ammarpad as the assignee of this task.Jul 22 2020, 5:10 AM
Ammarpad subscribed.
Ammarpad unsubscribed.
gerritbot added a comment.Aug 17 2020, 1:17 AM

Change 584573 abandoned by Ammarpad:
[mediawiki/core@master] Disable section editing on non-current revision.

Reason:

https://gerrit.wikimedia.org/r/584573

daniel added subscribers: Ammarpad, daniel.Sep 3 2020, 8:10 PM

@Ammarpad I see you abandoned the patch, has some other solution come up? Or was there a problem with the patch? I'm sorry you didn't get timely code review.

daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (External Code Reviews).Sep 4 2020, 2:43 PM
daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 4 2020, 2:48 PM
daniel added a comment.Sep 7 2020, 8:30 PM

I reviewed and tested the patch. It's good to be merged. I'd like to understand why it was abandoned, though.

gerritbot added a comment.Sep 8 2020, 6:52 PM

Change 584573 restored by Ammarpad:
[mediawiki/core@master] Disable section editing on non-current revision.

https://gerrit.wikimedia.org/r/584573

daniel moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Sep 9 2020, 3:47 PM
gerritbot added a comment.Sep 9 2020, 4:09 PM

Change 584573 merged by jenkins-bot:
[mediawiki/core@master] Disable section editing on non-current revision.

https://gerrit.wikimedia.org/r/584573

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 9 2020, 5:00 PM
Ammarpad closed this task as Resolved.Sep 9 2020, 5:13 PM
Ammarpad claimed this task.
matmarex mentioned this in T293313: TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given, called in /srv/mediawiki/php-1.38.0-wmf.3/includes/EditPage.php on line 646.Oct 13 2021, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits