Page MenuHomePhabricator

When redrawing the page to a new revision, please update mw.config.get('wgRevisionId')
Closed, ResolvedPublic1 Estimated Story Points

Description

Otherwise things that depend on it (e.g. VisualEditor) will act on the wrong page.

Event Timeline

Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptMar 23 2017, 9:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 344527 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/RevisionSlider@master] Update wgRevisionId when changed by slider

https://gerrit.wikimedia.org/r/344527

Actually on investigation, VE doesn't currently launch directly on diff pages at the moment, so the current edit link patching is sufficient, but this is still a good thing to do for the future.

Change 344527 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Update wgRevisionId when changed by slider

https://gerrit.wikimedia.org/r/344527

Jdforrester-WMF closed this task as Resolved.Mar 25 2017, 12:00 AM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF removed a project: Patch-For-Review.

Thanks!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 25 2017, 12:00 AM