SmashPig pending db pruner is broken
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	awight
	Mar 23 2017, 9:41 PM

Description

I just found 1.3M rows in the pending db, going back to its inception. Seems that our maintenance job is not a thing.

Details

	Subject	Repo	Branch	Lines +/-
	Update loadParamsAndArgs to use getOptionKit to fix errors causing	wikimedia/fundraising/SmashPig	master	+84 -72

Customize query in gerrit

Event Timeline

awight created this task.Mar 23 2017, 9:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2017, 9:41 PM

Most are paypal. There's a Jenkins config that should be pruning paypal messages after 14 days, but it's possible I screwed up the config matrix.

Ejegg triaged this task as Medium priority.Mar 28 2017, 9:21 PM

• ggellerman moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Mar 28 2017, 9:29 PM

Aha! Blame it on the homebrew getopt replacement in MaintenanceBase. For some reason, it treats options as boolean flags if the script doesn't specify a default value. However, the only option that any script actually does want to be a boolean flag is the --help option, added by MaintenanceBase itself. There's a big FIXME at the relevant line. @mepps is tearing out the custom argv parsing and replacing it with getopt.

Change 353383 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] Update loadParamsAndArgs to use getOptionKit to fix errors causing T161260

https://gerrit.wikimedia.org/r/353383

gerritbot added a project: Patch-For-Review.May 11 2017, 8:17 PM

Change 353383 had a related patch set uploaded (by Ejegg; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] Update loadParamsAndArgs to use getOptionKit to fix errors causing

https://gerrit.wikimedia.org/r/353383

Change 353383 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update loadParamsAndArgs to use getOptionKit to fix errors causing

https://gerrit.wikimedia.org/r/353383

Ejegg assigned this task to • mepps.May 12 2017, 7:48 PM

Ejegg added a project: Fundraising Sprint Judgement Suspenders.

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Judgement Suspenders board.

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Judgement Suspenders board.May 22 2017, 5:18 PM

Ejegg closed this task as Resolved.May 24 2017, 10:26 PM

Ejegg set the point value for this task to 2.

• mmodell removed a subscriber: awight.Jun 22 2017, 9:32 PM

• DStrine moved this task from Sprint +1 to Closed Early/Declined/Invalid Tasks on the Fundraising-Backlog board.Jul 6 2017, 4:52 PM

• DStrine added a project: Unplanned-Sprint-Work.Oct 18 2017, 4:16 PM