Defer visual diff run until the user clicks for it, rather than running immediately on load of the diff screen
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Mar 24 2017, 10:55 PM

Description

If nothing else, this avoids JS fatals from the v-diff blocking people from seeing what wikitext they've broken.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Defer rendering of visual diff until tab is selected	mediawiki/extensions/VisualEditor	master	+22 -6

Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Mar 24 2017, 10:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2017, 10:55 PM

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 25 2017, 1:09 AM

Change 344782 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/VisualEditor@master] Defer rendering of visual diff until tab is selected

https://gerrit.wikimedia.org/r/344782

gerritbot added a project: Patch-For-Review.Mar 25 2017, 1:15 PM

Jdforrester-WMF assigned this task to Esanders.Mar 25 2017, 8:47 PM

Change 344782 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Defer rendering of visual diff until tab is selected

https://gerrit.wikimedia.org/r/344782

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 25 2017, 9:00 PM

Jdforrester-WMF closed this task as Resolved.Mar 25 2017, 9:03 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 25 2017, 9:03 PM

Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 24 2017, 10:22 PM

Defer visual diff run until the user clicks for it, rather than running immediately on load of the diff screenClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Defer visual diff run until the user clicks for it, rather than running immediately on load of the diff screen
Closed, ResolvedPublic1 Estimated Story Points
Actions