Page MenuHomePhabricator
Create Task
Maniphest T161357

Fatal error when trying to review changes after editing within a <translate> tag
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

To reproduce, edit within a <translate> tag, click "Publish changes", then "Review your changes". This happened when I was trying to edit https://www.mediawiki.org/wiki/Manual:$wgCookieSetOnAutoblock

Chrome 56.0.2924.87 (64-bit), OS X Yosemite, Vector skin

Backtrace:

Uncaught TypeError: Cannot read property 'length' of undefined
    at VeUiDiffElement.ve.ui.DiffElement.getChangeDescriptionItem (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:463:276)
    at VeUiDiffElement.ve.ui.DiffElement.compareNodeAttributes (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:463:1)
    at VeUiDiffElement.highlightChangedNode (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:461:185)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeElements (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:461:877)
    at VeUiDiffElement.ve.ui.DiffElement.renderDiff (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:456:259)
    at new VeUiDiffElement (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:452:161)
    at VeUiMwSaveDialog.ve.ui.MWSaveDialog.setDiffAndReview (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:676:59)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.showChangesDiff (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:641:77)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.showChangesSuccess (eval at <anonymous> (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1:1), <anonymous>:640:824)
    at fire (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:45:122)
    at Object.fireWith [as resolveWith] (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:46:431)
    at Object.deferred.(anonymous function) (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:47:790)
    at fire (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:45:122)
    at Object.fireWith [as resolveWith] (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:46:431)
    at Object.deferred.(anonymous function) (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:47:790)
    at fire (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:45:122)
    at Object.fireWith [as resolveWith] (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:46:431)
    at done (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:135:766)
    at XMLHttpRequest.callback (https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:141:562)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWExtension describeChanges: Actually return value of parentmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Event Timeline

• MusikAnimal created this task.Mar 24 2017, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2017, 11:00 PM
Jdforrester-WMF triaged this task as High priority.Mar 24 2017, 11:07 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
gerritbot subscribed.Apr 3 2017, 8:58 PM

Change 346200 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/VisualEditor@master] MWExtension describeChanges: Actually return value of parent

https://gerrit.wikimedia.org/r/346200

gerritbot added a project: Patch-For-Review.Apr 3 2017, 8:58 PM
gerritbot added a comment.Apr 4 2017, 4:06 PM

Change 346200 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWExtension describeChanges: Actually return value of parent

https://gerrit.wikimedia.org/r/346200

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Apr 4 2017, 5:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 4 2017, 5:52 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 4 2017, 5:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits