Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Paladox
	Mar 25 2017, 10:16 PM

Description

Hi, i am getting these

Illegal string offset 'ltr' in /home/randomwi/public_html/en/extensions/Echo/includes/ResourceLoaderEchoImageModule.php on line 45

Errors in my error_log file.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Echo	master	+1 -1	Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php

Customize query in gerrit

Event Timeline

Paladox created this task.Mar 25 2017, 10:16 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 25 2017, 10:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Paladox updated the task description. (Show Details)Mar 26 2017, 11:32 PM

https://github.com/wikimedia/mediawiki-extensions-Echo/blob/7749ac4684d0839d541f4f922727613dfaeca7ac/includes/ResourceLoaderEchoImageModule.php#L40-L45

ResourceLoaderEchoImageModule.php

$paths = '';
if ( isset( $definition[ 'path' ] ) ) {
	if ( is_array( $definition[ 'path' ] ) ) {
		foreach ( $definition[ 'path' ] as $dir => $p ) {
			// Has both rtl and ltr definitions
			$paths[ $dir ] = $p;
		}
	} else {
		$paths = $definition[ 'path' ];

Looks like the first branch needs to first define $paths as an array before assigning a key to it.

Krinkle added a project: Technical-Debt.Mar 27 2017, 10:37 PM

Krinkle edited subscribers, added: Mooeypoo; removed: Krinkle.

Change 345070 had a related patch set (by Paladox) published:
[mediawiki/extensions/Echo@master] Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php

https://gerrit.wikimedia.org/r/345070

gerritbot added a project: Patch-For-Review.Mar 27 2017, 11:31 PM

In T161420#3135558, @Krinkle wrote:
https://github.com/wikimedia/mediawiki-extensions-Echo/blob/7749ac4684d0839d541f4f922727613dfaeca7ac/includes/ResourceLoaderEchoImageModule.php#L40-L45
ResourceLoaderEchoImageModule.php
$paths = '';
if ( isset( $definition[ 'path' ] ) ) {
	if ( is_array( $definition[ 'path' ] ) ) {
		foreach ( $definition[ 'path' ] as $dir => $p ) {
			// Has both rtl and ltr definitions
			$paths[ $dir ] = $p;
		}
	} else {
		$paths = $definition[ 'path' ];
Looks like the first branch needs to first define $paths as an array before assigning a key to it.