Page MenuHomePhabricator

ORES extension should fail gracefully when ORES service is unavailable
Closed, ResolvedPublic

Description

When the service is not available, the extension throws an exception, essentially rendering recent changes unavailable (and eventually history and whatever else is making use of ORES). Ideally it would just show an error message and display recent changes without any ORES data, to limit the fallout from operational problems with the ORES service.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Tgr, it's unclear whether this is the MediaWiki-extensions-ORES or Edit-Review-Improvements-RC-Page. I don't think the ORES extension causes this kind of problem. Can you clarify where and when you see this?

CC @Ladsgroup

Just point $wgOresBaseUrl to something that does not exist (while looking at a recentchanges row that has not been cached in the local DB yet).

Halfak triaged this task as High priority.Apr 14 2017, 4:17 PM
Halfak moved this task from Unsorted to Maintenance/cleanup on the Machine-Learning-Team board.

I want to fix this but I struggle to reproduce it. I changed $wgOresBaseUrl to foo.something and then I visited recent changes, then made an edit then visited recent changes. All was possible and without user-facing errors. Where did I do wrong? Do you mean in API?

Walking back from the throw clause in ORES\Api::request, this seems to happen when you are looking at a change list special page (trigger ChangesListSpecialPageStructuredFilters), ORES is enabled and the cache for ORES\Stats::fetchStats is cold.

Ladsgroup claimed this task.

This is resolved with the recent changes on the extension.