Page MenuHomePhabricator

References defined in templates can be 'edited' by pressing enter or double clicking
Closed, ResolvedPublic1 Estimated Story Points

Description

Editing should be disabled. While the edit button is hidden, the other two methods of launching the dialog still work)

Event Timeline

Esanders created this task.Mar 27 2017, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2017, 6:07 PM

Change 344978 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] Disable double-click & enter on focusable nodes when model is not editable

https://gerrit.wikimedia.org/r/344978

Change 344978 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Disable double-click & enter on focusable nodes when model is not editable

https://gerrit.wikimedia.org/r/344978

Change 344803 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (495cd7d65)

https://gerrit.wikimedia.org/r/344803

Change 344803 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (495cd7d65)

https://gerrit.wikimedia.org/r/344803

Jdforrester-WMF closed this task as Resolved.Mar 28 2017, 3:51 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 28 2017, 3:51 PM