Page MenuHomePhabricator
Create Task
Maniphest T161547

References defined in templates can be 'edited' by pressing enter or double clicking
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Editing should be disabled. While the edit button is hidden, the other two methods of launching the dialog still work)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (495cd7d65)mediawiki/extensions/VisualEditormaster+1 -1
Disable double-click & enter on focusable nodes when model is not editableVisualEditor/VisualEditormaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 27 2017, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2017, 6:07 PM
gerritbot subscribed.Mar 27 2017, 6:10 PM

Change 344978 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] Disable double-click & enter on focusable nodes when model is not editable

https://gerrit.wikimedia.org/r/344978

gerritbot added a project: Patch-For-Review.Mar 27 2017, 6:11 PM
gerritbot added a comment.Mar 27 2017, 10:10 PM

Change 344978 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Disable double-click & enter on focusable nodes when model is not editable

https://gerrit.wikimedia.org/r/344978

gerritbot added a comment.Mar 28 2017, 2:51 PM

Change 344803 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (495cd7d65)

https://gerrit.wikimedia.org/r/344803

gerritbot added a comment.Mar 28 2017, 3:08 PM

Change 344803 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (495cd7d65)

https://gerrit.wikimedia.org/r/344803

Jdforrester-WMF closed this task as Resolved.Mar 28 2017, 3:51 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-EditingTools, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 28 2017, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits