Page MenuHomePhabricator

Rollback has link to rollback in diff when not editrights to page
Closed, ResolvedPublic

Description

Author: laaknor-wmfbugzilla

Description:
User with rollback-access has "rollback"-link to administrator-only pages when viewing diff. In history, the link is not displayed.

Tested on no.wikipedia, with MediaWiki:, User:xxx/monobook.js and protected pages for administrators only.

Clicking the link only gives error, but the link should not be displayed when the user does not have access to it.


Version: 1.13.x
Severity: normal

Details

Reference
bz14155
TitleReferenceAuthorSource BranchDest Branch
make-release: Stop branching OSMrepos/releng/release!80taavimainmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:11 PM
bzimport set Reference to bz14155.
bzimport added a subscriber: Unknown Object (MLST).

Checks to see if a user can edit an article before generating a rollback link

I added getUserPermissionsErrors() from PageHistory.php

Attached: