In the media dialog, Command-Enter adds a blank line to the caption and closes the dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Mar 27 2017, 8:08 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

gerritbot

• Whatamidoing-WMF

Description

Steps to reproduce:

Insert > Media
Pick an image
Type a caption
Press Command–Enter

Expected result:
Dialog closes. I am happy.

Actual result:
Blank line is added to the end of the caption. Dialog closes. I am not happy.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MediaDialog: flag caption widget as being in a dialog	mediawiki/extensions/VisualEditor	master	+2 -1

Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Mar 27 2017, 8:08 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 27 2017, 8:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Whatamidoing-WMF updated the task description. (Show Details)Mar 27 2017, 8:09 PM

Change 345180 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] MediaDialog: flag caption widget as being in a dialog

https://gerrit.wikimedia.org/r/345180

gerritbot added a project: Patch-For-Review.Mar 28 2017, 4:44 PM

Jdforrester-WMF closed this task as Resolved.Mar 28 2017, 4:48 PM

Jdforrester-WMF assigned this task to DLynch.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 28 2017, 4:48 PM

Change 345180 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MediaDialog: flag caption widget as being in a dialog

https://gerrit.wikimedia.org/r/345180

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 28 2017, 5:00 PM

Jdforrester-WMF removed a project: Patch-For-Review.Mar 30 2017, 7:34 PM

Ryasmeen added projects: Verified, Verified-in-Phase0, Verified-in-Phase2.Apr 4 2017, 10:39 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 12 2017, 11:58 PM

In the media dialog, Command-Enter adds a blank line to the caption and closes the dialogClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

In the media dialog, Command-Enter adds a blank line to the caption and closes the dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions