I think it's time we cleaned all this up... :)
if ( $wgScribuntoUseGeSHi && $language ) { $geshi = SyntaxHighlight_GeSHi::prepare( $text, $language ); $geshi->set_language( $language ); if ( $geshi instanceof GeSHi && !$geshi->error() ) { $code = $geshi->parse_code(); if ( $code ) { // @todo Once we drop support for old versions of // Extension:SyntaxHighlight_GeSHi, drop the ugly test and // the BC case. global $wgAutoloadClasses; if ( isset( $wgAutoloadClasses['ResourceLoaderGeSHiModule'] ) ) { $output->addModuleStyles( "ext.geshi.language.$language" ); } else { // Backwards compatibility $output->addHeadItem( SyntaxHighlight_GeSHi::buildHeadItem( $geshi ), "source-{$language}" ); } if ( $wgUseSiteCss ) { $output->addModuleStyles( 'ext.geshi.local' ); } $output->setText( self::getPOText( $output ) . $code ); return $output; } } }
$geshi->error() is a complete noop, and also a void function