Page MenuHomePhabricator
Create Task
Maniphest T161611

Add serialize/deserialize methods to ve.dm.Transaction and ve.dm.IndexValueStore
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Code in ve.dm.Change can already serialize them, but they should handle their own serialization. This would make code cleaner and also help with ad-hoc testing.

For ve.dm.IndexValueStore, a value serializer/deserializer is needed in order to accomplish this.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (a6c25d08e)mediawiki/extensions/VisualEditormaster+1 -1
Serialize/deserialize for Transaction and IndexValueStoreVisualEditor/VisualEditormaster+103 -55
Customize query in gerrit

Related Objects

Event Timeline

dchan created this task.Mar 28 2017, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2017, 3:12 PM
gerritbot subscribed.Mar 28 2017, 3:14 PM

Change 344812 had a related patch set uploaded (by Divec):
[VisualEditor/VisualEditor@master] Serialize/deserialize for Transaction and IndexValueStore

https://gerrit.wikimedia.org/r/344812

gerritbot added a project: Patch-For-Review.Mar 28 2017, 3:14 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 28 2017, 3:15 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Mar 29 2017, 7:53 AM

Change 344812 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Serialize/deserialize for Transaction and IndexValueStore

https://gerrit.wikimedia.org/r/344812

gerritbot added a comment.Mar 31 2017, 3:13 AM

Change 345794 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6c25d08e)

https://gerrit.wikimedia.org/r/345794

gerritbot added a comment.Mar 31 2017, 9:12 PM

Change 345794 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6c25d08e)

https://gerrit.wikimedia.org/r/345794

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 31 2017, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 1 2017, 3:18 PM
Jdforrester-WMF edited projects, added Technical-Debt; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 1 2017, 3:18 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 12 2017, 11:53 PM
Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL