Page MenuHomePhabricator

"Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff
Closed, ResolvedPublic

Description

I just got "Uncaught TypeError: Cannot read property 'node' of undefined" when viewing visual diff after editing https://www.mediawiki.org/wiki/Extension:VisualEditor.

This kills the save dialog. It's impossible to close it or save the changes. Unless you're a developer, all your work is lost.

pasted_file (951×1 px, 293 KB)

Uncaught TypeError: Cannot read property 'node' of undefined
    at VeUiDiffElement.highlightRemovedNode (eval at <anonymous> (URL1:459:548)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeElements (eval at <anonymous> (URL1:461:788)
    at VeUiDiffElement.ve.ui.DiffElement.renderDiff (eval at <anonymous> (URL1:456:259)
    at new VeUiDiffElement (eval at <anonymous> (URL1:452:161)
    at VeUiMwSaveDialog.ve.ui.MWSaveDialog.setDiffAndReview (eval at <anonymous> (URL1:676:59)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.showChangesDiff (eval at <anonymous> (URL1:641:77)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.showChangesSuccess (eval at <anonymous> (URL1:640:824)
    at fire (URL1:45:122)
    at Object.fireWith [as resolveWith] (URL1:46:431)
    at Object.deferred.(anonymous function) (URL1:47:790)

URL1: https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF changed the task status from Open to Stalled.Mar 28 2017, 9:43 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This kills the save dialog. It's impossible to close it or save the changes. Unless you're a developer, all your work is lost.

Yeah, that's why we fixed that last week.

What was the content that caused the problem? Otherwise this report gives us nothing to go on.

Change 624270 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] ve.dm.VisualDiff: Don't return a diff if the tree diff times out

https://gerrit.wikimedia.org/r/624270

@matmarex @Jdlrobson - thanks for the examples. Timeouts aen't being handled properly, which is why this is happening on tables.

Change 624270 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.dm.VisualDiff: Don't return a diff if the tree diff times out

https://gerrit.wikimedia.org/r/624270

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Change 624789 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6f0390759)

https://gerrit.wikimedia.org/r/624789

Change 624789 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6f0390759)

https://gerrit.wikimedia.org/r/624789

ppelberg claimed this task.