Page MenuHomePhabricator
Create Task
Maniphest T161706

Review ORES prediction visibility on wikis where they are enabled by default
Closed, ResolvedPublic
Actions

Description

I have some important feedback from Polish Wikipedia, where people are surprised to have the red "r" (locally "p"), and have it staying even if they opt-in/opt-out the "Highlight probably damaging edits on Watchlist and Contributions (using ORES)" in their preferences.

I think we should change the "r" color to black (as @Catrope mentioned someday), but keep ORES predictions visible, because we didn't get any feedback against ORES predictions (ping @Halfak) and it is time to move forward.

The highlight option should be kept opted-out but rephrased to "Highlight more the probably damaging edits on Watchlist and Contributions" and turn the yellow highlighting on and turn the "r" to red.

Suggested improvements

  • Change the "R" default color from red to black
  • Turn the highlighting to off by default
  • When turned on, the R becomes red
  • Rephrase the opt-in sentence to "Highlight more the probably damaging edits on Watchlist and Contributions"

Details

SubjectRepoBranchLines +/-
Don't make the "r" red except when highlighting is activemediawiki/extensions/ORESwmf/1.29.0-wmf.18+8 -11
Don't make the "r" red except when highlighting is activemediawiki/extensions/ORESmaster+8 -11
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateQgilT125545 Phabricator Q&A session for Community Liaisons
 ResolvedQgilT116025 Goal: Align Community Liaison and Developer Relations project management practices
 ResolvedQgilT119387 Community Liaison and Developer Relation quarterly goals for January - March 2016
 OpenNoneT121500 Unify product documentation for users to make it easier to share, translate and edit
 ResolvedJohanT128790 Translation strategy – act and refine
 ResolvedTrizek-WMFT129088 Create an easy to maintain glossary to facilitate documentation translation (help pages and technical documentation)
 Resolved• jmatazzoniT145875 Create and maintain Edit Review Improvements documentation
 Resolved• DannyHT171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
 Resolved• DannyHT171981 Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions
 Resolved• jmatazzoniT157642 Graduate New Filters UX out of beta on Recent Changes on ALL wikis
 Resolved• jmatazzoniT144458 Launch ERI RC page features as a Beta Feature to all wikis
 Resolved• jmatazzoniT150715 Release strategy for RC page improvements: what wikis get the new features when?
 ResolvedTrizek-WMFT146669 Create dedicated pages for ERI Recent Changes Beta project
 Resolved• jmatazzoniT141449 Define Edit Review Improvements glossary
 Resolved• jmatazzoniT145157 Research current "new user" definitions and consider whether we need a different name for the ReviewStream and RC page “new user” flag / filter
 Resolved• jmatazzoniT151477 Improve Filters for Special:Recent Changes documentation page on mediawiki.org
 ResolvedTrizek-WMFT154889 Mark Edit Review Improvements glossary for translation
 ResolvedPginer-WMFT147632 Prototype an improved version of Recent Change designs
 Resolved• jmatazzoniT146333 Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals
 ResolvedCatropeT150959 Integrate a feedback page link in Recent Changes Beta filters
 ResolvedPginer-WMFT160063 Explore ways to represent visually the ORES-related filters and associated tradeoffs
 Resolved• jmatazzoniT161015 Add screenshots to the help pages for Recent Changes Filters Beta project
 OpenNoneT142782 Explore process for turning on RCPatrol for English and other relevant wikis
 ResolvedTrizek-WMFT158004 Release RC Page filtering to non-ORES wikis
 ResolvedTrizek-WMFT158225 Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (instead of behind a Beta Feature)
 ResolvedTrizek-WMFT159223 Inform communities about the release of the ORES good faith and damaging UI by default
 ResolvedTrizek-WMFT146972 Announce and follow up with communities about the New Filters for Recent changes Beta deployment
 ResolvedTrizek-WMFT158336 Announce and follow up with community group 1 about the New Filters for Recent changes Beta deployment
 ResolvedTrizek-WMFT158042 Followup with Polish Wikipedia about testing ERI filters for Recent Changes
 ResolvedCatropeT161706 Review ORES prediction visibility on wikis where they are enabled by default

Event Timeline

Trizek-WMF created this task.Mar 29 2017, 1:10 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 29 2017, 1:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF mentioned this in T160475: Manage ORES preferences on Watchlist (and Contributions).Mar 29 2017, 1:11 PM
Trizek-WMF added a parent task: T158042: Followup with Polish Wikipedia about testing ERI filters for Recent Changes.Mar 29 2017, 3:20 PM
gerritbot subscribed.Mar 29 2017, 5:23 PM

Change 345401 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/ORES@master] Don't make the "r" red and bold except when highlighting is active

https://gerrit.wikimedia.org/r/345401

gerritbot added a project: Patch-For-Review.Mar 29 2017, 5:23 PM
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage.Mar 29 2017, 5:24 PM
Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Trizek-WMF added a comment.Mar 29 2017, 5:56 PM

@Catrope, "r" is supposed to be bold, as "m" or "N", no?

Catrope added a comment.Mar 29 2017, 7:46 PM
In T161706#3141212, @Trizek-WMF wrote:

@Catrope, "r" is supposed to be bold, as "m" or "N", no?

Happy to keep it as bold if you guys think that's better...

Trizek-WMF added a comment.Mar 29 2017, 7:48 PM
This comment was removed by Trizek-WMF.
Trizek-WMF added a comment.Mar 29 2017, 7:49 PM
In T161706#3141607, @Catrope wrote:
In T161706#3141212, @Trizek-WMF wrote:

@Catrope, "r" is supposed to be bold, as "m" or "N", no?

Happy to keep it as bold if you guys think that's better...

I think it is better for consistency. :)

Catrope added a comment.Mar 29 2017, 7:54 PM

You're right, all the other ones are bold too. I've updated my patch.

Trizek-WMF updated the task description. (Show Details)Mar 30 2017, 8:57 AM
Trizek-WMF triaged this task as High priority.Mar 30 2017, 9:12 AM
gerritbot added a comment.Mar 30 2017, 7:17 PM

Change 345401 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Don't make the "r" red except when highlighting is active

https://gerrit.wikimedia.org/r/345401

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 30 2017, 8:00 PM
gerritbot added a comment.Mar 30 2017, 8:07 PM

Change 345648 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/ORES@wmf/1.29.0-wmf.18] Don't make the "r" red except when highlighting is active

https://gerrit.wikimedia.org/r/345648

gerritbot added a comment.Mar 30 2017, 11:02 PM

Change 345648 merged by jenkins-bot:
[mediawiki/extensions/ORES@wmf/1.29.0-wmf.18] Don't make the "r" red except when highlighting is active

https://gerrit.wikimedia.org/r/345648

Stashbot subscribed.Mar 30 2017, 11:07 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-30T23:07:49Z] <catrope@tin> Synchronized php-1.29.0-wmf.18/extensions/ORES/modules/: T161706 (duration: 00m 51s)

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)); removed MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 31 2017, 12:00 AM
Trizek-WMF mentioned this in T158042: Followup with Polish Wikipedia about testing ERI filters for Recent Changes.Apr 3 2017, 12:45 PM
SBisson assigned this task to Catrope.Apr 11 2017, 11:05 AM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Etonkovidova updated the task description. (Show Details)Apr 12 2017, 12:06 AM
Etonkovidova subscribed.Apr 12 2017, 12:11 AM

Regarding the following spec:

When turned on, the R becomes red

(1) 'r' is never red on RC page - even after disabling 'New filters for edit review' beta feature.

(2) If 'Highlight probably damaging edits on Watchlist and Contributions (using ORES)' option is ON, 'r' is displayed red on Watchlist and Contribution.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Apr 12 2017, 12:11 AM
• jmatazzoni closed this task as Resolved.Apr 18 2017, 12:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL