Template editing dialog completely broken by OOjs UI 0.20.1
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Mar 30 2017, 11:07 AM

Description

Not fields are show, and none can be added.

	Subject	Repo	Branch	Lines +/-
	GroupElement: Fix insertion bugs	oojs/ui	master	+16 -36

Mentioned Here: rGOJU6caaf523d67b: GroupElement: Transform to be an OO.EmitterList mixin
T159836: Unable to add template and parameters correctly with VisualEditor

Looks suspiciously like T159836, although that was filed weeks before OO UI 0.20.1, which bisect is blaming.

Esanders triaged this task as Unbreak Now! priority.Mar 30 2017, 11:11 AM

widget.addItems( [ new OO.ui.ButtonWidget( { label: 'derp' } ) ], widget.items.length );

GroupElement ends up trying to insert the new widget before itself when you do this, so it's never actually inserted:

this.items[ index ].$element.before( item.$element.get( 0 ) );

Change 345567 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] GroupElement: Fix insertion bugs

While debugging this I found another issue, also fixed in the patch.

Choices are rolling back the OOjs UI release or rolling forward 0.20.2 five days early. @Volker_E, your thoughts?

Change 345567 merged by jenkins-bot:
[oojs/ui@master] GroupElement: Fix insertion bugs

Volker_E closed this task as Resolved.Mar 30 2017, 11:08 PM

Volker_E moved this task from Backlog to OOjs-UI-0.20.2 on the OOUI board.

Volker_E edited projects, added OOUI (OOjs-UI-0.20.2); removed OOUI.

Volker_E removed a subscriber: gerritbot.

Jdforrester-WMF set the point value for this task to 8.Mar 31 2017, 2:27 AM