Page MenuHomePhabricator
Create Task
Maniphest T161806

Portal Dashboard: does not display US stats when grouping by region
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Found this on the Wikipedia Portal dashboard, while on the http://discovery.wmflabs.org/portal/#country_breakdown page and when grouping the US regions together - the US total stats don't appear.

portal-dashboard-US-stats-missing-when-grouped.png (562×1 px, 185 KB)

Details

ProjectBranchLines +/-Subject
wikimedia/discovery/princemaster+1 -1Fix data path in ui.R for full geo dashboard
wikimedia/discovery/dashboardmaster+2 -2Deploy fixes
wikimedia/discovery/princemaster+24 -29Fix U.S. grouping & full geo match bug
Customize query in gerrit

Related Objects
Search...

Event Timeline

debt created this task.Mar 30 2017, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2017, 4:29 PM
• chelsyx claimed this task.Mar 30 2017, 5:09 PM
• chelsyx moved this task from Backlog to In progress on the Discovery-Analysis (Current work) board.
• chelsyx added a subscriber: • chelsyx.

Looking into this problem.

On another dashboard http://discovery.wmflabs.org/portal/#all_country, the continent/region groupings went wrong. Not sure if this problem comes from the same source.

Screen Shot 2017-03-30 at 10.05.57 AM.png (559×807 px, 195 KB)

• chelsyx added a parent task: T162178: Fix data retrieval scripts using raw user agent strings.Apr 4 2017, 6:38 PM
• chelsyx moved this task from In progress to Stalled/Waiting on the Discovery-Analysis (Current work) board.
mpopov claimed this task.Apr 7 2017, 6:50 PM
mpopov raised the priority of this task from Medium to High.
mpopov moved this task from Stalled/Waiting to In progress on the Discovery-Analysis (Current work) board.
mpopov set the point value for this task to 4.
gerritbot added a subscriber: gerritbot.Apr 7 2017, 8:55 PM

Change 347110 had a related patch set uploaded (by Bearloga):
[wikimedia/discovery/prince@master] Fix U.S. grouping

https://gerrit.wikimedia.org/r/347110

gerritbot added a project: Patch-For-Review.Apr 7 2017, 8:55 PM
mpopov reassigned this task from mpopov to • chelsyx.Apr 7 2017, 8:58 PM
mpopov moved this task from In progress to Needs review on the Discovery-Analysis (Current work) board.
mpopov added a subscriber: mpopov.

Okay, I fixed the problem described in the ticket: https://gerrit.wikimedia.org/r/#/c/347110/ but have no idea where to even start with fixing the full geo breakdown so I'm handing this back to Chelsy.

• chelsyx moved this task from Needs review to In progress on the Discovery-Analysis (Current work) board.Apr 10 2017, 4:27 PM
• chelsyx moved this task from In progress to Needs review on the Discovery-Analysis (Current work) board.Apr 10 2017, 10:14 PM

Done. https://gerrit.wikimedia.org/r/#/c/347110/2/

In T161806#3165023, @mpopov wrote:

Okay, I fixed the problem described in the ticket: https://gerrit.wikimedia.org/r/#/c/347110/ but have no idea where to even start with fixing the full geo breakdown so I'm handing this back to Chelsy.

mpopov added a comment.Apr 11 2017, 7:02 PM

Patch live on https://discovery-beta.wmflabs.org/portal/#all_country; still need to do thorough CR but everything looks OK from a quick glance

gerritbot added a comment.Apr 11 2017, 9:56 PM

Change 347110 merged by Bearloga:
[wikimedia/discovery/prince@master] Fix U.S. grouping & full geo match bug

https://gerrit.wikimedia.org/r/347110

gerritbot added a comment.Apr 11 2017, 9:59 PM

Change 347776 had a related patch set uploaded (by Bearloga):
[wikimedia/discovery/dashboard@master] Deploy fixes

https://gerrit.wikimedia.org/r/347776

gerritbot added a comment.Apr 11 2017, 10:00 PM

Change 347776 merged by Bearloga:
[wikimedia/discovery/dashboard@master] Deploy fixes

https://gerrit.wikimedia.org/r/347776

mpopov moved this task from Needs review to Done on the Discovery-Analysis (Current work) board.Apr 11 2017, 10:02 PM

Fix is live in production. Thanks, @chelsyx!

gerritbot added a comment.Apr 12 2017, 12:54 AM

Change 347798 had a related patch set uploaded (by Chelsyx):
[wikimedia/discovery/prince@master] Fix data path in ui.R for full geo dashboard

https://gerrit.wikimedia.org/r/347798

• chelsyx added a comment.Apr 12 2017, 12:56 AM

@mpopov This is the fix for the date range on full geo dashboard:
https://gerrit.wikimedia.org/r/347798

Sorry it is late... :(

gerritbot added a comment.Apr 12 2017, 3:50 PM

Change 347798 merged by Bearloga:
[wikimedia/discovery/prince@master] Fix data path in ui.R for full geo dashboard

https://gerrit.wikimedia.org/r/347798

debt closed this task as Resolved.Apr 13 2017, 2:43 PM

Yay!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL