Page MenuHomePhabricator
Create Task
Maniphest T161811

Update LiquidThreads not to use deprecated EditPageBeforeEditChecks hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The hook was deprecated in https://gerrit.wikimedia.org/r/#/c/344805/ (MW 1.29).

Use 'EditPageGetCheckboxesDefinition' instead, or 'EditPage::showStandardInputs:options' if you don't actually care about checkboxes and just want to add some HTML to the page.

Details

SubjectRepoBranchLines +/-
Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinitionmediawiki/extensions/LiquidThreadswmf/1.29.0-wmf.20+10 -17
Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinitionmediawiki/extensions/LiquidThreadsmaster+10 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Mar 30 2017, 4:40 PM
Jdforrester-WMF triaged this task as High priority.Mar 30 2017, 5:16 PM
Jdforrester-WMF added a project: VisualEditor.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot subscribed.Mar 30 2017, 7:00 PM

Change 345630 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/LiquidThreads@master] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/345630

gerritbot added a project: Patch-For-Review.Mar 30 2017, 7:00 PM
Jdforrester-WMF claimed this task.Mar 30 2017, 7:05 PM
Aklapper added a project: Technical-Debt.Mar 31 2017, 8:08 AM
gerritbot added a comment.Apr 11 2017, 7:32 PM

Change 345630 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/345630

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 11 2017, 8:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 11 2017, 10:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 11 2017, 10:48 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 13 2017, 12:49 AM
gerritbot added a comment.Apr 13 2017, 3:30 PM

Change 348089 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/extensions/LiquidThreads@wmf/1.29.0-wmf.20] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/348089

gerritbot added a project: Patch-For-Review.Apr 13 2017, 3:30 PM
Jdforrester-WMF mentioned this in T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 3:56 PM
Jdforrester-WMF added a parent task: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 4:17 PM
gerritbot added a comment.Apr 13 2017, 6:16 PM

Change 348089 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.29.0-wmf.20] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/348089

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)); removed MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 7:00 PM
Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL