Page MenuHomePhabricator

Update LiquidThreads not to use deprecated EditPageBeforeEditChecks hook
Closed, ResolvedPublic1 Story Points

Description

The hook was deprecated in https://gerrit.wikimedia.org/r/#/c/344805/ (MW 1.29).

Use 'EditPageGetCheckboxesDefinition' instead, or 'EditPage::showStandardInputs:options' if you don't actually care about checkboxes and just want to add some HTML to the page.

Event Timeline

matmarex created this task.Mar 30 2017, 4:40 PM
Jdforrester-WMF triaged this task as High priority.Mar 30 2017, 5:16 PM
Jdforrester-WMF added a project: VisualEditor.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 345630 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/LiquidThreads@master] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/345630

Change 345630 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/345630

Jdforrester-WMF closed this task as Resolved.Apr 11 2017, 10:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 11 2017, 10:48 PM

Change 348089 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/extensions/LiquidThreads@wmf/1.29.0-wmf.20] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/348089

Change 348089 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.29.0-wmf.20] Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition

https://gerrit.wikimedia.org/r/348089