Page MenuHomePhabricator

Page-Previews is dependent on BetaFeatures
Closed, ResolvedPublic1 Story Points

Description

The documentation on mediawiki says:

There is also an optional dependency on Beta Features (without BetaFeatures, it loads for all users) and Extension:EventLogging (for logging).

But if you don't install BetaFeatures you get Class undefined: HTMLFeatureField.

Event Timeline

Prtksxna created this task.Mar 30 2017, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2017, 6:49 PM

Change 345642 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/Popups@master] Remove hard dependency on BetaFeatures

https://gerrit.wikimedia.org/r/345642

That patch gets rid of the error for me. But I still cant get the extension to work. It blanks out the title attribute but doesn't show the card. Surely not related to this issue, but @Jdlrobson a little help?

We will soon be migrating page previews out of beta features over the course of the month at which point this will magically solve itself.

It may create more work for us now to fix it so we should be mindful of that.

Change 345642 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove hard dependency on BetaFeatures

https://gerrit.wikimedia.org/r/345642

phuedx added a subscriber: phuedx.Mar 30 2017, 9:02 PM

I've tested rEPOPd9d2be5de4a9: Remove hard dependency on BetaFeatures locally by not loading the BetaFeatures extension and it WFM. @Prtksxna has also tested it too (thanks @Prtksxna!).

phuedx closed this task as Resolved.Mar 30 2017, 9:02 PM
phuedx claimed this task.

Per the above.

Jdlrobson set the point value for this task to 1.Mar 30 2017, 9:11 PM

fair?

yes, 1 story point sounds good. Thanks for fixing that issue