Page MenuHomePhabricator

ProofreadPage's VisualEditor integration doesn't load correctly when launched from view mode of non-existing page
Open, HighPublic1 Estimated Story Points

Description

When trying to create https://fr.wikisource.org/w/index.php?title=Page:Rivard_-_Manuel_de_la_parole,_traité_de_prononciation,_1901.djvu/110 using VisualEditor (using the "create" toolbar button, not the switch between Wikitext and VE) the contentEditable part is still cluttered by the "not existing page" message.

Event Timeline

The 404 part is intentional (it's the defined part of the API for how to see if a page doesn't exist) – https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js;285a078b219cf7a298b9a62932c694dda5bb20c6$226.

I'm not sure what you mean by the CE being cluttered?

I'm not sure what you mean by the CE being cluttered?

For example in [1] the system message [2] stating that the page does not exists is not removed.

[1] https://fr.wikisource.org/wiki/Page:Rivard_-_Manuel_de_la_parole,_traité_de_prononciation,_1901.djvu/182?veaction=edit
[2] "Il n’y a pour l’instant aucun texte sur cette page ; vous pouvez lancer une recherche sur le titre de cette page ou modifier cette page."

Oh, right, yes, the ProofreadPage integration needs to take care of that – VE's wikipage integration does (see https://fr.wikisource.org/wiki/scasccas?veaction=edit), but you're not inheriting from that fully I believe?

Jdforrester-WMF renamed this task from VisualEditor on not existing Page: pages does a 404 request to the API to ProofreadPage's VisualEditor integration doesn't hide the `noarticletext`<div> on load on new pages.Apr 1 2017, 3:37 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

It also doesn't load the page image, and in general fails quite spectacularly:

image.png (980×1 px, 114 KB)

Most users don't run into this problem because it works fine when opening VE from the default URL for non-existing pages (e.g. https://fr.wikisource.org/w/index.php?title=Page:Rivard_-_Manuel_de_la_parole,_traité_de_prononciation,_1901.djvu/110&action=edit&redlink=1). You have to load the editor from a view-mode URL (e.g. https://fr.wikisource.org/wiki/Page:Rivard_-_Manuel_de_la_parole,_traité_de_prononciation,_1901.djvu/110).

matmarex renamed this task from ProofreadPage's VisualEditor integration doesn't hide the `noarticletext`<div> on load on new pages to ProofreadPage's VisualEditor integration doesn't load correctly when launched from view mode of non-existing page.Jun 11 2018, 8:57 PM
matmarex updated the task description. (Show Details)