Page MenuHomePhabricator
Create Task
Maniphest T161877

Visual diffs get duplicated if you go back to editing from the "Review your changes" dialog and then return to that dialog without making any new changes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page in VE
  2. Change something
  3. Click on "Save changes"
  4. Click on "Review your changes"
  5. Click on "Visual"
  6. Click on "Resume editing"
  7. Don't change anything
  8. Repeat steps 3 through 5 (scroll down if necessary)

Actual results:
The diffs are duplicated depending on how many times you go back and forth without changing anything.

Expected results:
A single diff should have been shown.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (19a6c389c)mediawiki/extensions/VisualEditormaster+1 -1
Remove DiffElement DOM element when destroyingVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Srdjan created this task.Mar 31 2017, 8:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2017, 8:43 AM
Srdjan renamed this task from Visual diff duplicates changes if you go back to editing from the "Review your changes" dialog and then return to that dialog without making any new changes to Visual diffs get duplicated if you go back to editing from the "Review your changes" dialog and then return to that dialog without making any new changes.Mar 31 2017, 8:43 AM
Schnark merged a task: T161937: Visual diff repeats the whole chunk of changes every time I re-open it.Apr 1 2017, 7:56 AM
Schnark added subscribers: Ryasmeen, Jdforrester-WMF.
gerritbot subscribed.Apr 3 2017, 9:09 PM

Change 346201 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] Remove DiffElement DOM element when destroying

https://gerrit.wikimedia.org/r/346201

gerritbot added a project: Patch-For-Review.Apr 3 2017, 9:09 PM
gerritbot added a comment.Apr 4 2017, 3:49 PM

Change 346201 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove DiffElement DOM element when destroying

https://gerrit.wikimedia.org/r/346201

gerritbot added a comment.Apr 4 2017, 5:42 PM

Change 346327 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (19a6c389c)

https://gerrit.wikimedia.org/r/346327

gerritbot added a comment.Apr 4 2017, 6:38 PM

Change 346327 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (19a6c389c)

https://gerrit.wikimedia.org/r/346327

Jdforrester-WMF closed this task as Resolved.Apr 4 2017, 6:41 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 4 2017, 6:41 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)); removed Patch-For-Review.Apr 4 2017, 6:48 PM
Ryasmeen added a project: Verified.Apr 4 2017, 10:25 PM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM
Ryasmeen added a project: Verified-in-Phase0.Apr 13 2017, 12:33 AM
Ryasmeen added a project: Verified-in-Phase2.Apr 26 2017, 8:28 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL