Page MenuHomePhabricator

Save dialog too small after switching to diff and back again
Open, LowPublic1 Story Points


Steps to reproduce (tested in Firefox):

  1. Open a page in VE, change something.
  2. Click "Save", note that the size is correct.
  3. Click "Review your changes", and "Back to save".

Expected: The dialog should have the same size as in step 2.
Actual: It is smaller, using a scroll bar. It looks like the height stayed the same, but the width decreased. Or perhaps even the width stayed the same, but the scrollbar is there decreasing the usable width and thus making the scrollbar necessary.

step 2step 3

Event Timeline

Schnark created this task.Mar 31 2017, 9:27 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 31 2017, 9:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Was the dialog less tall on the diff page?

Yes, the diff page had a smaller height and a larger width. When you get a diff that is longer than the save page, no scrollbar is shown when you return.

Jdforrester-WMF triaged this task as Normal priority.Apr 4 2017, 7:26 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana lowered the priority of this task from Normal to Low.Jul 26 2017, 9:45 AM
Deskana added a subscriber: Deskana.

I'm not seeing this problem, but the dialogue seems large enough to fit the entire wall of text with space to spare. If I make my window smaller, a scroll bar is present no matter what I do.

It seems like Schnark's screen size is right at a sweet spot where there's no scrollbar unless you make the dialogue slightly smaller. This is a legitimate issue, and the dialogue shouldn't resize, but it causing a practical issue is an edge case.

Deskana moved this task from TR1: Releases to Freezer on the VisualEditor board.Jul 26 2017, 9:46 AM