Page MenuHomePhabricator
Create Task
Maniphest T161895

For MediaWiki extensions, merge composer test into mwext-textextension / mediawiki-extensions jobs
Closed, ResolvedPublic
Actions

Description

Most MediaWiki repositories now have a composer test. The PHPUnit tests already install the composer dev dependencies and thus we should be able to run composer test directly in the job that runs the PHPUnit tests.

Benefits:

  • we stop triggering the composer tests extra jobs that consume instances
  • if lint/style fails, the PHPUnit jobs are not run at all and feedback is given faster

Since some MediaWiki repositories might lack a composer.json or a test entry point, we would have to take that in account.

Details

SubjectRepoBranchLines +/-
Run composer test from mediawiki-extensions jobsintegration/configmaster+19 -18
Run composer test from mediawiki-extensions jobsintegration/configmaster+19 -18
mwext-testextension now runs composer testintegration/configmaster+43 -346
Allow composer-test to run in different directoryintegration/configmaster+13 -3
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Mar 31 2017, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2017, 1:26 PM
hashar added a project: Continuous-Integration-Infrastructure (Little Steps Sprint).Mar 31 2017, 1:26 PM
hashar updated the task description. (Show Details)
hashar mentioned this in T160989: Revisit Jenkins jobs being triggered for Wikibase.
Paladox subscribed.Mar 31 2017, 6:15 PM
hashar claimed this task.May 5 2017, 1:23 PM
hashar triaged this task as Medium priority.
hashar moved this task from Backlog to On going on the Continuous-Integration-Infrastructure (Little Steps Sprint) board.
gerritbot subscribed.May 5 2017, 1:24 PM

Change 352128 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Allow composer-test to run in different directory

https://gerrit.wikimedia.org/r/352128

gerritbot added a project: Patch-For-Review.May 5 2017, 1:24 PM
gerritbot added a comment.May 5 2017, 2:44 PM

Change 352160 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] mwext-testextension now runs composer test

https://gerrit.wikimedia.org/r/352160

hashar added a comment.May 9 2017, 9:46 AM

There are a few extensions having a composer.json file but that lacks a scripts.test entry. With the testextension job now invoking composer test that would fail.

Note: some extensions trigger the mediawiki-extensions-* jobs that do not run composer test so they are unaffected.

List:

$ (for f in `ls */composer.json`; do echo -n "$f: "; jq -c '.scripts.test' "$f"; done;)|grep 'null'
BlueSpiceExtendedSearch/composer.json: null
BlueSpiceSMWConnector/composer.json: null
CirrusSearch/composer.json: null
DataTransfer/composer.json: null
FundraisingEmailUnsubscribe/composer.json: null
GoogleAnalyticsTopPages/composer.json: null
GoogleGeocode/composer.json: null
Html2Wiki/composer.json: null
LinkedWiki/composer.json: null
NotebookViewer/composer.json: null
NumerAlpha/composer.json: null
OOUIPlayground/composer.json: null
OpenIDConnect/composer.json: null
PipeEscape/composer.json: null
PubSubHubbub/composer.json: null
reCaptcha/composer.json: null
SecureSessions/composer.json: null
SemanticHighcharts/composer.json: null
SemanticSifter/composer.json: null
SideBarMenu/composer.json: null
SwiftMailer/composer.json: null
UserFunctions/composer.json: null
WebPlatformAuth/composer.json: null
Wikidata/composer.json: null
WindowsAzureSDK/composer.json: null
hashar mentioned this in rEREC5b6ecb50a72c: build: add parallel-lint.May 9 2017, 11:17 AM
Umherirrender mentioned this in rMSMAa12eb1208479: Add php-parallel-lint.May 9 2017, 6:48 PM
Umherirrender mentioned this in R1893:1ca0d7a58fdb: Add php-parallel-lint.
Umherirrender mentioned this in rMSMA8029fe4ee762: Add php-parallel-lint.
Umherirrender subscribed.May 9 2017, 7:19 PM

For all extensions from above now exists patch sets, also for skins Refreshed and Material

Umherirrender mentioned this in rEBSSMWC40820c894f63: Add php-parallel-lint.May 9 2017, 8:18 PM
gerritbot added a comment.May 10 2017, 7:42 AM

Change 352128 merged by jenkins-bot:
[integration/config@master] Allow composer-test to run in different directory

https://gerrit.wikimedia.org/r/352128

Stashbot subscribed.May 10 2017, 8:04 AM

Mentioned in SAL (#wikimedia-releng) [2017-05-10T08:04:57Z] <hashar> merging 'composer test' into mwext-testextension-* jobs https://gerrit.wikimedia.org/r/#/c/352160/ - T161895

gerritbot added a comment.May 10 2017, 8:08 AM

Change 352160 merged by jenkins-bot:
[integration/config@master] mwext-testextension now runs composer test

https://gerrit.wikimedia.org/r/352160

Umherirrender mentioned this in rMSMA826db25a55ff: Add php-parallel-lint.May 10 2017, 3:41 PM
Umherirrender mentioned this in rMSMA68b00d608fc2: Add php-parallel-lint.May 10 2017, 3:50 PM
Umherirrender mentioned this in R1893:f9a7fb67ed81: Add php-parallel-lint.May 12 2017, 2:27 PM
Umherirrender closed this task as Resolved.May 12 2017, 6:30 PM
Paladox mentioned this in R1893:6ddaf971b0a9: Add php-parallel-lint.May 13 2017, 8:41 PM
hashar moved this task from On going to Done: verify me on the Continuous-Integration-Infrastructure (Little Steps Sprint) board.May 22 2017, 10:32 AM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptMay 22 2017, 10:32 AM
hashar reopened this task as Open.May 29 2017, 1:07 PM

I have forgot to merge composer into the mediawiki-extensions-* jobs.

gerritbot added a comment.May 29 2017, 2:02 PM

Change 356047 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Run composer test from mediawiki-extensions jobs

https://gerrit.wikimedia.org/r/356047

hashar moved this task from Done: verify me to On going on the Continuous-Integration-Infrastructure (Little Steps Sprint) board.Jun 5 2017, 11:51 AM
gerritbot added a comment.Jun 5 2017, 1:30 PM

Change 356047 merged by jenkins-bot:
[integration/config@master] Run composer test from mediawiki-extensions jobs

https://gerrit.wikimedia.org/r/356047

gerritbot added a comment.Jun 5 2017, 2:06 PM

Change 357209 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Run composer test from mediawiki-extensions jobs

https://gerrit.wikimedia.org/r/357209

hashar moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Jun 6 2017, 10:54 AM
gerritbot added a comment.Jun 6 2017, 1:33 PM

Change 357209 merged by jenkins-bot:
[integration/config@master] Run composer test from mediawiki-extensions jobs

https://gerrit.wikimedia.org/r/357209

hashar closed this task as Resolved.Jun 6 2017, 1:37 PM

For mediawiki-extensions jobs: after MediaWiki has been installed, the job cd to the extension and composer install && composer test.

Solved via https://gerrit.wikimedia.org/r/#/c/357209/ + a JJB patch https://review.openstack.org/#/c/471030/

Tobi_WMDE_SW awarded a token.Jun 6 2017, 1:44 PM
hashar moved this task from In-progress to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.Jun 27 2017, 9:05 PM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:46 PM
hashar mentioned this in rENBVf37d0093972d: build: add parallel-lint.May 25 2023, 6:54 PM
Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 7:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL