Page MenuHomePhabricator

CentralNotice: Remove unused code for banner preview in banner editor
Open, NormalPublic2 Story Points

Description

It seems there's unused code for banner previews in an iframe as part of the banner editor. We should remove this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2017, 4:19 PM

Change 345862 had a related patch set uploaded (by AndyRussG):
[mediawiki/extensions/CentralNotice@master] Comments flagging possibly unused code for inline banner previews

https://gerrit.wikimedia.org/r/345862

awight added a subscriber: awight.Apr 4 2017, 1:05 AM

Yes, thank you! Any future work on banner previews will probably be to add language and country options to the wiki preview link.

Change 345862 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Comments flagging possibly unused code for inline banner previews

https://gerrit.wikimedia.org/r/345862

ggellerman triaged this task as Normal priority.Apr 4 2017, 9:23 PM
ggellerman set the point value for this task to 2.
mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM
Base added a subscriber: Base.Apr 6 2018, 7:03 PM
Base added a comment.Apr 6 2018, 7:11 PM

Can this task be reversed to actually add a banner preview while editing?

When creating banners I am forced to use such handmade makeshift preview: https://meta.wikimedia.org/wiki/User:Base/CNBannerEditpreview.js and of course it does not cover everything I need and still forces me to save the edit (which as per another bug is slow), view live preview, and repeat it many times, sometimes to do something as trivial as getting the font-size right.

I have no concerns if it is easier to remove whatever legacy unused code and just build a new previewer from scratch in the future though

Change 484784 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/CentralNotice@master] [WIP] Remove unused banner preview support

https://gerrit.wikimedia.org/r/484784

Ejegg added a subscriber: Ejegg.Feb 13 2019, 9:35 PM

diagonal banner list on Special:CentralNoticeBanners in Firefox:

diagonal banner list on Special:CentralNoticeBanners in Firefox:

I was able to reproduce the issue by zooming out, and confirmed that it doesn't happen without my patch.

Change 484784 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove unused banner preview support

https://gerrit.wikimedia.org/r/484784