Page MenuHomePhabricator

Icons/Indicators should be set to `display: none` by default and only be visible when set
Closed, DuplicatePublic

Description

As of v0.20.2 icons (*iconElement-icon) and indicators (*indicatorElement-indicator) are in the DOM output even when not set.
Not only are the in the output, they are also not consistently set to display: none letting them end up unnecessarily in the render tree, which has a, probably small, but still negative performance effect.

Example:

T161177 icon&indicator positioning Dropdown _before - OOjs UI Demos 2017-03-31.png (458×1 px, 52 KB)