Page MenuHomePhabricator

Using en-gb as language breaks Api tests
Closed, ResolvedPublic

Description

20) ApiMainTest::testApiErrorFormatterCreation with data set "uselang=content" (array('content', 'plaintext'), array('en-gb', 'ApiErrorFormatter', 'en-gb', 'plaintext', false))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-en-gb
+en

/var/www/wiki/mediawiki/core/tests/phpunit/includes/api/ApiMainTest.php:326
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:400
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:111

21) ApiMainTest::testApiErrorFormatterCreation with data set "errorlang=content" (array('content', 'plaintext'), array('ru', 'ApiErrorFormatter', 'en-gb', 'plaintext', false))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-en-gb
+en

Event Timeline

Reedy created this task.Apr 3 2017, 12:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2017, 12:59 AM
Anomie claimed this task.Apr 3 2017, 1:43 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.

Change 346150 had a related patch set uploaded (by Anomie):
[mediawiki/core@master] Fix ApiMainTest::testApiErrorFormatterCreation

https://gerrit.wikimedia.org/r/346150

Change 346150 merged by jenkins-bot:
[mediawiki/core@master] Fix ApiMainTest::testApiErrorFormatterCreation

https://gerrit.wikimedia.org/r/346150

Anomie closed this task as Resolved.Apr 3 2017, 2:53 PM