Maniphest T162025

[Bug] JS for showing and editing Statements on Lexeme page does not work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jonas
	Apr 3 2017, 10:02 AM

Description

It straight goes to edit mode when calling a Lexeme page, and editing does not work as expected.
It seems there is a problem with data values in JS.

Details

	Subject	Repo	Branch	Lines +/-
	Fix: JS for showing and editing Statements on Lexeme page does not work	mediawiki/extensions/WikibaseLexeme	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWLE8412d0227c7e: Fix: JS for showing and editing Statements on Lexeme page does not work

Event Timeline

• Jonas created this task.Apr 3 2017, 10:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2017, 10:02 AM

• Jonas triaged this task as High priority.Apr 3 2017, 10:02 AM

• Jonas moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.

It seems that ControllerViewFactory.getStatementView() is called with null as value and this is causing it to go directly to edit mode on page load (ControllerViewFactory:137).

49947921 subscribed.Apr 3 2017, 10:21 AM

49947921 moved this task from incoming to ready to go on the Wikidata board.Apr 3 2017, 10:27 AM

• Jonas added a project: Regression.Apr 3 2017, 10:30 AM

49947921 added a project: Google-Summer-of-Code.Apr 3 2017, 10:36 AM

Lydia_Pintscher removed a project: Google-Summer-of-Code.Apr 3 2017, 2:25 PM

Further investigated:

entity.getStatements();

In getStatementGroupListView() in ViewFactory.js does not return Statements.

• Jonas claimed this task.Apr 5 2017, 10:17 AM

• Jonas moved this task from Backlog to Doing on the Wikidata-Former-Sprint-Board board.

Change 346518 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix: JS for showing and editing Statements on Lexeme page does not work

https://gerrit.wikimedia.org/r/346518

gerritbot added a project: Patch-For-Review.Apr 5 2017, 10:19 AM

• Jonas moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Apr 5 2017, 10:20 AM

• Jonas mentioned this in rEWLE8412d0227c7e: Fix: JS for showing and editing Statements on Lexeme page does not work.Apr 5 2017, 10:20 AM

Change 346518 merged by Jonas Kress (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Fix: JS for showing and editing Statements on Lexeme page does not work

https://gerrit.wikimedia.org/r/346518

• Aleksey_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Apr 8 2017, 9:32 AM

• Jonas closed this task as Resolved.Apr 10 2017, 12:32 PM

[Bug] JS for showing and editing Statements on Lexeme page does not workClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[Bug] JS for showing and editing Statements on Lexeme page does not work
Closed, ResolvedPublic
Actions