Page MenuHomePhabricator

IE11 - checkboxes for RC filters cannot be checked
Closed, ResolvedPublic

Description

On RC page, click to open the filter selection drop-down menu. Initially, a checkbox can be checked. But subsequent clicks do not produce any results. The same with un-checking.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 3 2017, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E added a subscriber: Volker_E.

I see this when testing:

  1. After page load, it looks fine:
  2. After clicking, it shifts up, but the clickable area stays the same as before:
  3. It doesn't shift back when unchecked:

Just adding .oo-ui-checkboxInputWidget { display: block; } to the CSS seems to fix it. (CheckboxInputWidget is a <span>, so it's display inline normally; it used to be a <div> before 362ba3897549b25502bdf759a0721df0a8bc385c.) I guess IE11 doesn't like the combination of the position: relative inside display: inline inside display: table-cell (from FieldLayout) for some reason.

I'm not sure if there is anything to fix in OOjs UI here. I think something about the RCFilters interface specifically is causing this. Unless someone can reproduce with a plain OOjs UI checkbox, I think we should only do the workaround for RCFilters.

Change 346210 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/core@master] RCFilters: Work around IE11 rendering issues

https://gerrit.wikimedia.org/r/346210

Change 346210 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Work around IE11 rendering issues

https://gerrit.wikimedia.org/r/346210

Volker_E closed this task as Resolved.Apr 6 2017, 12:11 AM
Volker_E removed projects: Patch-For-Review, OOUI.
Volker_E removed a subscriber: gerritbot.