Page MenuHomePhabricator

Add accelerator keys (keyboard shortcuts) for forms in Wikilabels
Open, LowPublic

Description

Use case:
From my personal experience, most of the time spent in scoring articles goes not to reading the diff, but to clicking on the two options. Adding accelerator keys for these five buttons can greatly improve scoring efficiency.

Given that T98681: Add accessKey option TextInputWidget and RadioOptionWidget/RadioInputWidget is done, we should be able to implement this now.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Arthur2e5 renamed this task from Accelerator keys in scoring webpage to Accelerator keys in scoring gadget.Apr 4 2017, 1:35 AM
Halfak renamed this task from Accelerator keys in scoring gadget to Keyboard shortcuts for forms in Wiki labels.Apr 13 2017, 2:54 PM
Halfak triaged this task as Low priority.
Halfak updated the task description. (Show Details)
Halfak moved this task from Unorganized to New development on the Machine-Learning-Team board.
Halfak added a subscriber: Halfak.

Probably want to add this to the form configuration.

Aklapper renamed this task from Keyboard shortcuts for forms in Wiki labels to Add accelerator keys (keyboard shortcuts) for forms in Wikilabels.Nov 25 2017, 8:30 PM
Aryan040501 added a subscriber: Aryan040501.
This comment was removed by Aryan040501.
This comment was removed by Aryan040501.

Hi and welcome @Aryan040501! If you have specific questions, then please elaborate. Thanks a lot!

Could you please help me with what to do? I am not being able to understand where to add accelerator keys

@Aryan040501: Hi, what have you tried so far in the Wikilabels code repository, and what have you looked up so far?

I read the html, css and js files for the forms in the template.
I also read a little about the handling of data using flask/python.

But I could not find the 5 buttons specified in the task.

@Aryan040501: Hi! This task has been assigned to you a while ago. How is it going?
When it comes to finding buttons, have you tried to search the code base?

$:acko\> grep -r "TextInputWidget" .
./forms/available/unsourced_statements.yaml:      class: "TextInputWidget"
./forms/available/draft_notability.yaml:      class: "TextInputWidget"
./forms/available/edit_type.yaml:      class: "TextInputWidget"
./wikilabels/wsgi/static/js/oo.util.js:			case OO.ui.TextInputWidget:
./wikilabels/wsgi/templates/form_builder.html:      class: "TextInputWidget"
$:acko\> grep -r "RadioOptionWidget" .
./forms/available/draft_notability.yaml:         - class: "RadioOptionWidget"
./wikilabels/wsgi/static/js/oo.util.js:			case OO.ui.RadioOptionWidget:
$:acko\> grep -r "RadioInputWidget" .
./wikilabels/wsgi/static/js/oo.util.js:			case OO.ui.RadioInputWidget:

@Aklapper I just submitted my PR.

I just added the accelerator keys to focus on the specific widgets.