Page MenuHomePhabricator

Consider not showing the visual diff option when creating pages (as there's no difference, it's just a green preview)
Closed, DeclinedPublic1 Estimated Story Points

Description

When you create a new page, and click on "Review your changes" in the save dialog, instead of the usual diff just the generated wikitext is shown (as a diff would just show this wikitext to be added).
Since the visual diff has been introduced, it is possible to show this in visual format, too, but as there is no wikitext diff, this doesn't feel right, and the displayed visual diff is rather redundant: It shows one removal of an empty paragraph or such (which is wrong), and an insertion of everything else (which is just the content of the editing surface with a green background).
I don't think that the visual diff should be provided for page creations. The "Review your changes" in this case actually doesn't let you review your changes, but instead let's you review the wikitext generated by Parsoid.

Event Timeline

Jdforrester-WMF renamed this task from Don't show visual diff when creating pages to Consider not showing the visual diff option when creating pages (as there's no difference, it's just a green preview).Apr 4 2017, 7:06 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

It's not that helpful - but the alternative is just disable half of the diff page (the user may still want to see the wikitext diff) which may look a little odd. It's also not inconceivable that they forgot they were creating the page from scratch.

It may also be helpful to show the diff, even though it's somewhat empty, to keep the interface consistent and set the expectation with the user that there will be diffs there for their other edits.

I want to just note that this is not true for some edits/users

What is not true? You're not replying to anyone, so it's not clear from what you've written. :-)

Sorry, never mind my misplaced comment :)

Is this resolved then, or should we have some further discussion about the best user interface?