Clicking on Notices/Alerts issues a banner over the other icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Niharika
	Apr 4 2017, 6:20 PM

Description

Steps to reproduce:

Go to https://deployment.wikimedia.beta.wmflabs.org/wiki/Main_Page
Click on Alerts if you have any Notices or vice versa.
A little banner appears over the other icon.

Probably related to https://gerrit.wikimedia.org/r/#/c/345969/

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
[wip] Use formatted text label for echo badge icons in different skins	mediawiki/extensions/Echo	master	+41 -14
Revert "Do not use fancy styled badge on Modern and CologneBlue"	mediawiki/extensions/Echo	wmf/1.29.0-wmf.19	+31 -42
Revert "Do not use fancy styled badge on Modern and CologneBlue"	mediawiki/extensions/Echo	master	+31 -42

Customize query in gerrit

Related Objects

Mentioned In: T141944: Consider not using icons in Modern and CologneBlue skins for notifications

Event Timeline

Niharika created this task.Apr 4 2017, 6:20 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 4 2017, 6:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Niharika added a subscriber: matmarex.Apr 4 2017, 6:20 PM

Change 346334 had a related patch set uploaded (by Mooeypoo):
[mediawiki/extensions/Echo@master] Revert "Do not use fancy styled badge on Modern and CologneBlue"

https://gerrit.wikimedia.org/r/346334

gerritbot added a project: Patch-For-Review.Apr 4 2017, 6:40 PM

Change 346334 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Revert "Do not use fancy styled badge on Modern and CologneBlue"

https://gerrit.wikimedia.org/r/346334

Change 346341 had a related patch set uploaded (by Catrope; owner: Mooeypoo):
[mediawiki/extensions/Echo@wmf/1.29.0-wmf.19] Revert "Do not use fancy styled badge on Modern and CologneBlue"

https://gerrit.wikimedia.org/r/346341

Change 346343 had a related patch set uploaded (by Mooeypoo):
[mediawiki/extensions/Echo@master] Use formatted text label for echo badge icons in different skins

https://gerrit.wikimedia.org/r/346343

Change 346341 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.29.0-wmf.19] Revert "Do not use fancy styled badge on Modern and CologneBlue"

https://gerrit.wikimedia.org/r/346341

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 4 2017, 8:00 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-04T20:48:22Z] <catrope@tin> Synchronized php-1.29.0-wmf.19/extensions/Echo/: T162173 (duration: 00m 43s)

Catrope closed this task as Resolved.May 9 2017, 7:27 PM

Catrope claimed this task.

Change 346343 abandoned by Mooeypoo:
[wip] Use formatted text label for echo badge icons in different skins

Reason:
Deprioritized; if anyone wants to pick this back up (and see how to also fix the bug that the code is blocked on) feel free.