Page MenuHomePhabricator
Create Task
Maniphest T162201

Cleanup artifacts of related pages desktop beta feature
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

  • Clean unused user preference for beta feature being enabled (read-more)
  • Remove use of blacklist in config (https://gerrit.wikimedia.org/r/346453). This should be deployed on or after 13th April 2017.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove use of blacklist for related pages featureoperations/mediawiki-configmaster+0 -7
Remove use of blacklist for related pages featureoperations/mediawiki-configmaster+0 -6
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 4 2017, 10:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2017, 10:19 PM
Jdlrobson added a project: RelatedArticles.Apr 4 2017, 10:19 PM
gerritbot subscribed.Apr 4 2017, 10:20 PM

Change 346453 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config@master] Remove use of blacklist for related pages feature

https://gerrit.wikimedia.org/r/346453

gerritbot added a project: Patch-For-Review.Apr 4 2017, 10:20 PM
Jdlrobson mentioned this in T160076: Disable related pages on desktop beta mode.Apr 4 2017, 10:20 PM
Jdlrobson changed the task status from Open to Stalled.Apr 4 2017, 10:33 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
Jdlrobson added projects: Reading-Web-Sprint-95, Unplanned-Sprint-Work.Apr 7 2017, 8:29 PM

Might as well do this during the latter part of the sprint as otherwise we'll probably forget. Blocked until 13th

Jdlrobson moved this task from Needs Analysis to Blocked Externally on the Reading-Web-Sprint-95 board.Apr 7 2017, 8:30 PM
Jdlrobson moved this task from Triaged but Future to 2016-17 Q3 on the Web-Team-Backlog-Archived board.
MBinder_WMF added subscribers: ovasileva, MBinder_WMF.Apr 11 2017, 5:11 PM

Does this needs points? Priority? @ovasileva

Jdlrobson added a subscriber: • Tgr.Apr 11 2017, 5:39 PM

@Tgr any ideas on how to cleanup user preferences after disabling a beta feature?

Jdlrobson set the point value for this task to 2.Apr 11 2017, 5:48 PM
ovasileva triaged this task as High priority.Apr 12 2017, 11:39 AM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptApr 12 2017, 11:39 AM
Jdlrobson added a comment.Apr 12 2017, 7:47 PM

Looks like we do not need to clean up user preference.

<•greg-g> jdlrobson: I'd ask James_F, he knows the most about beta features (not really a releng thing)
11:01 AM niedzielski-afk → niedzielski
11:01 AM J<James_F> James D. Forrester jdlrobson: I believe the Official Advice™ from RelEng (but greg-g can correct) is "please don't try to delete old user preferences, it's risky and not that valuable".
11:01 AM J<jdlrobson> Jon Robson James_F: great. Just wanted to check.
11:01 AM J<James_F> James D. Forrester jdlrobson: Other than that, it just needs dropping from config/etc.
Jdlrobson updated the task description. (Show Details)Apr 12 2017, 7:47 PM
• Tgr added a comment.Apr 12 2017, 9:03 PM
In T162201#3172508, @Jdlrobson wrote:

@Tgr any ideas on how to cleanup user preferences after disabling a beta feature?

You'd have to run an SQL query manually to delete the right property from user_properties + betafeatures_user_counts. I agree about it not being valuable.

Dereckson moved this task from Backlog to External on the Wikimedia-Site-requests board.Apr 13 2017, 8:26 AM
Jdlrobson moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-95 board.Apr 13 2017, 4:19 PM

This can be SWATed from 4pm PST.

Jdlrobson moved this task from To Do to Needs Code Review on the Reading-Web-Sprint-95 board.Apr 13 2017, 4:20 PM
Jdlrobson changed the task status from Stalled to Open.Apr 13 2017, 4:23 PM
Jdlrobson claimed this task.
MBinder_WMF moved this task from 2016-17 Q3 to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Apr 13 2017, 7:09 PM
gerritbot added a comment.Apr 13 2017, 11:32 PM

Change 346453 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove use of blacklist for related pages feature

https://gerrit.wikimedia.org/r/346453

Stashbot subscribed.Apr 13 2017, 11:41 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-13T23:41:54Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Remove use of blacklist for related pages feature (T162201) (duration: 00m 40s)

Stashbot added a comment.Apr 13 2017, 11:43 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-13T23:43:10Z] <niharika29@tin> Synchronized wmf-config/CommonSettings.php: Remove use of blacklist for related pages feature (T162201) (duration: 00m 40s)

gerritbot added a comment.Apr 13 2017, 11:48 PM

Change 348176 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config@master] Remove use of blacklist for related pages feature

https://gerrit.wikimedia.org/r/348176

Stashbot added a comment.Apr 13 2017, 11:51 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-13T23:51:01Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Revert Remove use of blacklist for related pages feature (T162201) (duration: 00m 41s)

Stashbot added a comment.Apr 13 2017, 11:56 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-13T23:56:02Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Retry sync Revert Remove use of blacklist for related pages feature (T162201) (duration: 00m 40s)

gerritbot added a comment.Apr 14 2017, 12:00 AM

Change 348176 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove use of blacklist for related pages feature

https://gerrit.wikimedia.org/r/348176

Stashbot added a comment.Apr 14 2017, 12:02 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-14T00:02:13Z] <niharika29@tin> Synchronized wmf-config/CommonSettings.php: Remove use of blacklist for related pages feature (T162201) (duration: 00m 41s)

Stashbot added a comment.Apr 14 2017, 12:03 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-14T00:03:11Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Remove use of blacklist for related pages feature (T162201) (duration: 00m 41s)

Jdlrobson closed this task as Resolved.Apr 14 2017, 12:14 AM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-95 board.
Jdlrobson updated the task description. (Show Details)

This is a technical task and all the clean up is now done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits