Page MenuHomePhabricator

enwiki file "Lock_icon_blue.gif" in sites CSS has to be switched to commons wiki
Closed, ResolvedPublic

Description

See this link: https://it.wikivoyage.org/wiki/Middelburg#In_aereo

  • "Aeroporto di Rotterdam" and "Aeroporto di Eindhoven" have https link but on their right have a blank space instead of the https icon
  • "Aeroporto di Schiphol" has an http link and in its right has the regular external http link icon

Several project CSS files refers to background: url(//upload.wikimedia.org/wikipedia/en/0/00/Lock_icon_blue.gif) for the external links. However that file has been deleted on the english wiki (enwiki delete request).

Thus all CSS have to instead point to commons:

background: url('//upload.wikimedia.org/wikipedia/commons/0/00/Lock_icon_blue.gif')

Status

List generated on July 19th 2017 13:40 UTC using:

mwgrep 'wikipedia/en/0/00/Lock_icon_blue.gif'

66 wikis

WikiPage
arwikiMediaWiki:Gadget-style.css
arwikiMediaWiki:Modern.css
arwikiMediaWiki:Monobook.css
astwikiMediaWiki:Simple.css
aswikiMediaWiki:Vector.css
azwikiMediaWiki:Monobook.css
bjnwikiMediaWiki:Vector.css
bnwikiMediaWiki:Monobook.css
bugwikiMediaWiki:Vector.css
cdowikiMediaWiki:Monobook.css
cywikiMediaWiki:Monobook.css
eswikiquoteMediaWiki:Common.css
gagwikiMediaWiki:Monobook.css
gagwikiMediaWiki:Vector.css
gawiktionaryMediaWiki:Vector.css
glwikiMediaWiki:Vector.css
glwikibooksMediaWiki:Vector.css
glwikiquoteMediaWiki:Vector.css
glwikisourceMediaWiki:Vector.css
guwikiMediaWiki:Monobook.css
gvwikiMediaWiki:Vector.css
iawikiMediaWiki:Monobook.css
idwikiMediaWiki:Modern.css
idwikibooksMediaWiki:Vector.css
idwikisourceMediaWiki:Vector.css
kawikiMediaWiki:Vector.css
kwwikiMediaWiki:Vector.css
liwikiMediaWiki:Vector.css
lvwikiMediaWiki:Monobook.css
lvwikiMediaWiki:Vector.css
minwikiMediaWiki:Vector.css
mnwikiMediaWiki:Vector.css
mtwikiMediaWiki:Monobook.css
mtwikiMediaWiki:Vector.css
mywiktionaryMediaWiki:Vector.css
orwikiMediaWiki:Vector.css
pswikiMediaWiki:Modern.css
pswiktionaryMediaWiki:Vector.css
shwikiMediaWiki:Modern.css
shwikiMediaWiki:Monobook.css
shwikiMediaWiki:Vector.css
siwikiMediaWiki:Modern.css
siwikiMediaWiki:Monobook.css
siwikibooksMediaWiki:Modern.css
siwikibooksMediaWiki:Monobook.css
siwikibooksMediaWiki:Simple.css
siwikibooksMediaWiki:Vector.css
siwiktionaryMediaWiki:Modern.css
siwiktionaryMediaWiki:Monobook.css
siwiktionaryMediaWiki:Simple.css
siwiktionaryMediaWiki:Vector.css
slwikiMediaWiki:Vector.css
sqwikiMediaWiki:Vector.css
tawikiMediaWiki:Vector.css
tawiktionaryMediaWiki:Vector.css
tewikiMediaWiki:Vector.css
thwikiMediaWiki:Vector.css
tlwikiMediaWiki:Vector.css
trwikiMediaWiki:Monobook.css
ttwikibooksMediaWiki:Monobook.css
uzwikiMediaWiki:Vector.css
warwikiMediaWiki:Monobook.css
yiwikiMediaWiki:Vector.css
yowikiMediaWiki:Monobook.css
yowikiMediaWiki:Vector.css
zh_yuewikiMediaWiki:Monobook.css

Event Timeline

Andyrom75 created this task.Apr 5 2017, 7:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2017, 7:05 AM

Hi @Andyrom75, thanks for taking the time to report this! Confirming.

If you right-click on any of those two links and choose "Inspect element", the CSS will show:

#bodyContent a.external[href^="https://"], .link-https {
    background: url(//upload.wikimedia.org/wikipedia/en/0/00/Lock_icon_blue.gif) center right no-repeat;
    padding-right: 16px;

Going to https://upload.wikimedia.org/wikipedia/en/0/00/Lock_icon_blue.gif that is a 404 error.

(Unrelated: https://commons.wikimedia.org/wiki/File:Lock_icon_blue.gif and hence https://upload.wikimedia.org/wikipedia/commons/0/00/Lock_icon_blue.gif exist but that is a different URL.)

Aklapper renamed this task from https external links do not show anyrome the "locker icon" on Wikivoyage to "Lock_icon_blue.gif" (used in CSS for external links in articles) is a 404 error.Apr 5 2017, 9:32 AM
Aklapper triaged this task as High priority.
hashar added a subscriber: hashar.Apr 5 2017, 11:02 AM

The enwiki version of the file ( https://en.wikipedia.org/wiki/File:Lock_icon_blue.gif ) has been deleted on March 20th in favor of using the version from commons.

The deletion request is at https://en.wikipedia.org/wiki/Wikipedia:Files_for_discussion/2017_March_20#File:Lock_icon_blue.gif

The css thus has to be updated. I will update the task detail with a list of pages that need to be fixed.

hashar renamed this task from "Lock_icon_blue.gif" (used in CSS for external links in articles) is a 404 error to enwiki file "Lock_icon_blue.gif" in sites CSS has to be switched to commons wiki.Apr 5 2017, 11:07 AM
hashar removed a project: media-storage.
hashar updated the task description. (Show Details)

One can probably fill a request for mass update by a bot via https://en.wikipedia.org/wiki/Wikipedia:Bot_requests

@Aklapper modifying MediaWiki:Vector.css‎ with the commons image, the correct behaviour has been restored.
Thanks.

Samtar awarded a token.Jul 6 2017, 8:02 PM
hashar updated the task description. (Show Details)Jul 19 2017, 1:45 PM

I have updated the list. There are 66 entries.

Samtar claimed this task.Jul 20 2017, 7:04 AM

I've recently changed this on simplewiki, so I'd be happy to go through the list and manually update them - I'm all for automation, but I think given there is only 66 being able to do them one by one and confirming the change worked correctly outweighs the benefits of doing it in one shot. I've requested temporary global editinterface so that I can make these non-controversial maintenance edits

hashar added a comment.EditedJul 20 2017, 9:13 PM

Thank you @Samtar I guess I was assuming that lot of bot operators already have global edit interface right. That is why I suggested to reach out to them to automatize the edition. But your idea is way easier and as you said, it is "only" 66 edits :-}

Poke this task once your are done, I will be happy to run the mwgrep command to verify.

I can do this if nobody else manages in a few days, let me know.

@hashar Could you confirm the above have been dealt with? I could not find the link on the following

shwikiMediaWiki:Modern.css
shwikiMediaWiki:Monobook.css
shwikiMediaWiki:Vector.css