Page MenuHomePhabricator

Missing warning when removing article from offline when article is on multiple lists
Closed, ResolvedPublic2 Estimated Story Points

Description

Missing warning dialog when action is taken to remove article offline availability when that article is on multiple lists

Steps to reproduce

  1. Add the same article to two reading lists (by default, the article will be made available offline).
  2. Go to one reading list and remove that article from being available offline

Expected

Warning dialog message is shown advising that the article appears on multiple reading lists, with bullet point list of all lists containing that article:
Dialog will ask for a confirmation to "Remove from offline" or allow user to "Cancel".

Dialog text:

TitleArticle appears in multiple lists
Text<Article name> will no longer be available offline for all reading lists:
• <List name>
• <List name>
Actions[Cancel] or [Remove from offline]

Actual

Article is removed from offline on all lists with no warning dialog

Event Timeline

Change 353350 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] WIP: Warn user before setting multi-list page to online-only

https://gerrit.wikimedia.org/r/353350

Change 353350 merged by jenkins-bot:
[apps/android/wikipedia@master] Warn user before setting a page appearing in multiple lists to online-only

https://gerrit.wikimedia.org/r/353350

ABorbaWMF subscribed.

Tested on Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 and the Alpha App 2.5.195-alpha-2017-05-16

Looks good, tested on multiple lists and articles. Controls work when offline and on. Ready for signoff.