The HistoryFragment currently shows a list of recently visited pages using a ListView but RecyclerViews better support swipe operations and nested scrolling. Update the HistoryFragment to use a RecyclerView instead.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T146913 [API 19] History nav bar doesn't autohide | |||
| Resolved | Dbrant | T146650 Allow swipe-to-delete for History items. | |||
| Resolved | Dbrant | T162280 Convert HistoryFragment to use a RecyclerView |
Event Timeline
Comment Actions
Change 349962 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia@master] Make HistoryFragment use a RecyclerView instead of ListView.
Comment Actions
Change 349963 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia@master] Enable multi-selection in History fragment.
Comment Actions
Change 349962 merged by jenkins-bot:
[apps/android/wikipedia@master] Make HistoryFragment use a RecyclerView instead of ListView.
Comment Actions
Change 349963 merged by jenkins-bot:
[apps/android/wikipedia@master] Enable multi-selection in History fragment.
Comment Actions
For QA:
Make sure the History screen behaves like before:
- Tapping an item in the History screen should correctly navigate to the selected page.
- Long-pressing an item in the History screen should enter a multi-selection mode, where you can select multiple items for deletion.
- Searching within the History screen should work as before.
Comment Actions
Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-26
Everything appears to work fine, including swipe to delete.