Page MenuHomePhabricator
Create Task
Maniphest T162324

[Regression] Clicking settings cog as anonymous user doesn't do anything
Closed, ResolvedPublic
Actions

Description

Observed on cawiki and hewiki....
As an anonymous user, when I click on the settings cog nothing happens.
Expected: the settings dialog opens.

In JS console:

Uncaught TypeError: Cannot read property 'preventDefault' of undefined
    at Object.showSettings (eval at <anonymous> (load.php?debug=false&lang=he&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1), <anonymous>:368:964)
    at HTMLAnchorElement.eval (eval at <anonymous> (load.php?debug=false&lang=he&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:1), <anonymous>:380:816)
    at HTMLAnchorElement.dispatch (load.php?debug=false&lang=he&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:65)
    at HTMLAnchorElement.elemData.handle (load.php?debug=false&lang=he&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1ljmhq7:60)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
renderer: Pass event to behavior for processingmediawiki/extensions/Popupswmf/1.29.0-wmf.19+13 -3
renderer: Pass event to behavior for processingmediawiki/extensions/Popupsmaster+13 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 5 2017, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2017, 11:36 PM
Jdlrobson triaged this task as High priority.Apr 5 2017, 11:37 PM
Jdlrobson added a project: Unplanned-Sprint-Work.
Jdlrobson added a subscriber: ovasileva.

@ovasileva this may qualify as an unbreak now as I suspect the bug will be on all wikis tomorrow. I can swat a fix tomorrow if we can work out the root cause...

Jdlrobson added a comment.Apr 5 2017, 11:56 PM

Looks like this was introduced by rEPOP29963edb09c5: preview: Add click behavior and should be easy to fix.

gerritbot subscribed.Apr 5 2017, 11:56 PM

Change 346668 had a related patch set uploaded (by Jdlrobson):
[mediawiki/extensions/Popups@master] Pass event to showSettings

https://gerrit.wikimedia.org/r/346668

gerritbot added a project: Patch-For-Review.Apr 5 2017, 11:56 PM
• bmansurov added subscribers: phuedx, • Jhernandez, • bmansurov.Apr 6 2017, 12:12 AM

@phuedx / @Jhernandez would you mind reviewing the above patch and possibly SWAT deploying the fix during the European hours before the bug hits production? Thanks!

Aklapper added a project: Page-Previews.Apr 6 2017, 8:49 AM

I assume this is about Page-Previews.

phuedx added a comment.EditedApr 6 2017, 8:54 AM
In T162324#3159825, @Aklapper wrote:

I assume this is about Page-Previews.

You assume correctly (read: Thanks, @Aklapper!).

phuedx added a comment.Apr 6 2017, 9:53 AM

FTR I've reverted @bmansurov's PS. While I do agree with @bmansurov's, it'd introduce another regression: the click event handler would also be triggered when clicking the settings cog.

It's clear that the ext.Popups.PreviewBehavior abstraction is leaky and needs either a little more work or to be brought closer to/merged into the renderer but that's out of scope of this task.

gerritbot added a comment.Apr 6 2017, 9:53 AM

Change 346720 had a related patch set uploaded (by Phuedx; owner: Jdlrobson):
[mediawiki/extensions/Popups@wmf/1.29.0-wmf.19] renderer: Pass event to behavior for processing

https://gerrit.wikimedia.org/r/346720

gerritbot added a comment.Apr 6 2017, 10:08 AM

Change 346668 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] renderer: Pass event to behavior for processing

https://gerrit.wikimedia.org/r/346668

• Jhernandez assigned this task to phuedx.Apr 6 2017, 10:15 AM
• Jhernandez moved this task from Needs Analysis to Needs More Work on the Reading-Web-Sprint-95 board.

Assigning to @phuedx for the swat. I've qad and merged the patch and qad and +1d the swat cherry pick.

phuedx added a comment.Apr 6 2017, 10:19 AM

I've scheduled rEPOP2f62d7dd73d1: renderer: Pass event to behavior for processing for today's European SWAT.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 6 2017, 11:00 AM
ovasileva mentioned this in T161125: Strange behavior when viewing page previews on Stage 0 Wikis.Apr 6 2017, 11:27 AM
gerritbot added a comment.Apr 6 2017, 1:09 PM

Change 346720 merged by jenkins-bot:
[mediawiki/extensions/Popups@wmf/1.29.0-wmf.19] renderer: Pass event to behavior for processing

https://gerrit.wikimedia.org/r/346720

Stashbot subscribed.Apr 6 2017, 1:20 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-06T13:20:51Z] <hashar@tin> Synchronized php-1.29.0-wmf.19/extensions/Popups: renderer: Pass event to behavior for processing - T162324 (duration: 00m 51s)

phuedx moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-95 board.Apr 6 2017, 1:34 PM

I've tested both the logged in and out flows and they both work as expected.

phuedx renamed this task from Clicking settings cog as anonymous user doesn't do anything to [Regression] Clicking settings cog as anonymous user doesn't do anything.Apr 6 2017, 1:34 PM
phuedx raised the priority of this task from High to Unbreak Now!.
phuedx moved this task from Incoming to 2016-17 Q3 on the Web-Team-Backlog-Archived board.
phuedx added a project: Regression.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptApr 6 2017, 1:35 PM
phuedx added a comment.Apr 6 2017, 1:36 PM
In T162324#3159262, @Jdlrobson wrote:

@ovasileva this may qualify as an unbreak now as I suspect the bug will be on all wikis tomorrow. I can swat a fix tomorrow if we can work out the root cause...

You're right. This is/was definitely a regression.

• Jhernandez reassigned this task from phuedx to ovasileva.Apr 6 2017, 1:36 PM

I've tested in ca.wikipedia.org and it seems fixed.

Off to @ovasileva for signoff

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)); removed MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 6 2017, 2:00 PM
ovasileva closed this task as Resolved.Apr 6 2017, 2:20 PM

tested on hewiki and cawiki - looks good.

Jdlrobson added a comment.Apr 6 2017, 2:40 PM

Good team work all!

MBinder_WMF moved this task from 2016-17 Q3 to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Apr 13 2017, 7:09 PM
Volker_E removed a project: Patch-For-Review.Apr 18 2018, 7:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits